Liping Zhang <zlpnob...@gmail.com> wrote: > Yes, here we should use clear_bit(IPS_SRC_NAT_DONE_BIT, &ct->status); > (For IPS_DST_NAT_DONE, we don't care about it, so we can > leave it unchanged.)
Oh, right. > > Thats also broken(racy). We have to audit all the non-atomic writes of > > ct->status and change them to set/clear_bit()... > > I audited the related codes just now, this seems to be the last > ct->status writer which use non-atomic bit operation(of course, > except these unconfirmed ct->status writer). > > I will have a further and closer check. If you are not opposed to, > I can send a related patch to fix this. :) That would be great, thanks Liping! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
