>> This new operation allows to import ruleset in json to make >> incremental changes using the parse functions of libnftnl. >> >> A basic way to test this new functionality is: >> >> % cat file.json | nft import json >> >> where the file.json is a ruleset exported in json format. >> >> Highly based on work from Alvaro Neira <[email protected]> >> and Arturo Borrero <[email protected]>. >> >> Signed-off-by: Shyam Saini <[email protected]> >> --- >> V2: >> Build Patch over updated repository. > > > Hi Shyam,
Hi Arturo, > I was able to test this with the testcase you provided in the other > patch! great! :-) > Thank You Arturo, > One last thing, the coding style should be fixed before we can merge > this into master. Examples below. > We follow linux kernel coding style [0]. There is a script to check > coding style [1], but beware of some false positives (regarding the > commit message). > > Other than that, the patch looks fine. Please, address the coding > style issues, and resend with: > > Acked-by: Arturo Borrero Gonzalez <[email protected]> I'll send the new version of this patch > >> + >> +static int netlink_markup_build_rule(const struct nftnl_parse_ctx *ctx, >> + uint32_t cmd, struct >> nftnl_rule *rule) >> +{ > > ^^^ > bad alignment, indentation, produces long lines. > >> + >> +static int netlink_markup_chain(const struct nftnl_parse_ctx *ctx) >> +{ >> + const struct ruleset_parse *rp; >> + struct nftnl_chain *chain; >> + uint32_t cmd; >> + int ret = -1; >> + >> + chain = nftnl_ruleset_ctx_get(ctx, NFTNL_RULESET_CTX_CHAIN); >> + rp = nftnl_ruleset_ctx_get(ctx, NFTNL_RULESET_CTX_DATA); >> + >> + nftnl_chain_unset(chain, NFTNL_CHAIN_HANDLE); >> + >> + cmd = nftnl_ruleset_ctx_get_u32(ctx, NFTNL_RULESET_CTX_CMD); >> + switch (cmd) { >> + case NFTNL_CMD_ADD: >> + ret = mnl_nft_chain_batch_add(chain, rp->nl_ctx->batch, 0, >> rp->nl_ctx->seqnum); >> + break; >> + case NFTNL_CMD_DELETE: >> + ret = mnl_nft_chain_batch_del(chain, rp->nl_ctx->batch, 0, >> rp->nl_ctx->seqnum); > ^^ > too long lines > > > [0] https://www.kernel.org/doc/html/v4.10/process/coding-style.html > [1] https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
