This eliminates the need for that temporary buffer.

Signed-off-by: Phil Sutter <[email protected]>
---
 src/exthdr.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/exthdr.c b/src/exthdr.c
index 4add3da24ad87..37c7688401f60 100644
--- a/src/exthdr.c
+++ b/src/exthdr.c
@@ -31,17 +31,13 @@ static void exthdr_expr_print(const struct expr *expr, 
struct output_ctx *octx)
                 * multiplicator
                 */
                unsigned int offset = expr->exthdr.offset / 64;
-               char buf[9] = {0};
 
-               if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT) {
-                       printf("tcp option %s", expr->exthdr.desc->name);
+               printf("tcp option %s", expr->exthdr.desc->name);
+               if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT)
                        return;
-               }
-
                if (offset)
-                       snprintf(buf, sizeof buf, "%d", offset);
-               printf("tcp option %s%s %s", expr->exthdr.desc->name, buf,
-                                            expr->exthdr.tmpl->token);
+                       printf("%d", offset);
+               printf(" %s", expr->exthdr.tmpl->token);
        } else {
                if (expr->exthdr.flags & NFT_EXTHDR_F_PRESENT)
                        printf("exthdr %s", expr->exthdr.desc->name);
-- 
2.13.1

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to