Hi Harsha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf/master]
[also build test ERROR on v4.15-rc7 next-20180110]
[cannot apply to nf-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-nf_tables-delete-table-via-table-handle/20180111-153748
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net//netfilter/nf_tables_api.c: In function '__nft_table_lookup_byhandle':
>> net//netfilter/nf_tables_api.c:375:22: error: 'struct nft_table' has no 
>> member named 'handle'
      if (handle == table->handle &&
                         ^~
   net//netfilter/nf_tables_api.c: In function 'nf_tables_deltable':
>> net//netfilter/nf_tables_api.c:890:66: error: 'NFTA_TABLE_HANDLE' undeclared 
>> (first use in this function); did you mean 'NFTA_RULE_HANDLE'?
     if (family == AF_UNSPEC || (nla[NFTA_TABLE_NAME] == NULL && 
nla[NFTA_TABLE_HANDLE] == NULL))
                                                                     
^~~~~~~~~~~~~~~~~
                                                                     
NFTA_RULE_HANDLE
   net//netfilter/nf_tables_api.c:890:66: note: each undeclared identifier is 
reported only once for each function it appears in

vim +375 net//netfilter/nf_tables_api.c

   368  
   369  static struct nft_table *__nft_table_lookup_byhandle(const struct 
nft_af_info *afi,
   370                                                       u64 handle, u8 
genmask)
   371  {
   372          struct nft_table *table;
   373  
   374          list_for_each_entry(table, &afi->tables, list) {
 > 375                  if (handle == table->handle &&
   376                      nft_active_genmask(table, genmask))
   377                          return table;
   378          }
   379          return NULL;
   380  }
   381  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to