Hi Harsha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-nft_ct-add-ct-timeout-support/20180714-095128
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: i386-randconfig-x015-201827 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/netfilter/nft_ct.c: In function 'nft_ct_timeout_obj_destroy':
>> net/netfilter/nft_ct.c:901:3: error: implicit declaration of function 
>> 'nf_ct_untimeout'; did you mean 'nf_ct_netns_put'? 
>> [-Werror=implicit-function-declaration]
      nf_ct_untimeout(ctx->net, priv->timeout);
      ^~~~~~~~~~~~~~~
      nf_ct_netns_put
   cc1: some warnings being treated as errors

vim +901 net/netfilter/nft_ct.c

   890  
   891  static void nft_ct_timeout_obj_destroy(const struct nft_ctx *ctx,
   892                                         struct nft_object *obj)
   893  {
   894          struct nft_ct_timeout_obj *priv = nft_obj_data(obj);
   895  
   896          nf_ct_tmpl_free(priv->tmpl);
   897  
   898          if (refcount_dec_if_one(&priv->timeout->refcnt)) {
   899                  nf_ct_l4proto_put(priv->timeout->l4proto);
   900                  list_del_rcu(&priv->timeout->head);
 > 901                  nf_ct_untimeout(ctx->net, priv->timeout);
   902          }
   903  }
   904  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to