Hi Harsha,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-cttimeout-move-ctnl_untimeout-to-nf_conntrack/20180714-095352
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/netfilter/nf_conntrack_timeout.c:38:62: sparse: incompatible types in 
>> comparison expression (different base types)

vim +38 net/netfilter/nf_conntrack_timeout.c

    33  
    34  static int untimeout(struct nf_conn *ct, void *timeout)
    35  {
    36          struct nf_conn_timeout *timeout_ext = nf_ct_timeout_find(ct);
    37  
  > 38          if (timeout_ext && (!timeout || timeout_ext->timeout == 
timeout))
    39                  RCU_INIT_POINTER(timeout_ext->timeout, NULL);
    40  
    41          /* We are not intended to delete this conntrack. */
    42          return 0;
    43  }
    44  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to