On 06/07/18 09:34, Dan Carpenter wrote: > Hello Edward Cree, > > The patch 7da517a3bc52: "net: core: Another step of skb receive list > processing" from Jul 2, 2018, leads to the following static checker > warning: > > net/core/dev.c:5001 netif_receive_skb_list_internal() > warn: 'skb' was already freed. > > The patch 17266ee93984: "net: ipv4: listified version of ip_rcv" from > Jul 2, 2018, leads to the following static checker warning: > > ./include/linux/netfilter.h:301 NF_HOOK_LIST() > warn: 'skb' was already freed. > > [...] > > do_xdp_generic() frees skb. > > [...] > > For this one Smatch thinks that nf_hook() sometimes frees skb, but the > code is less clear to me than for the previous warning so I don't know. Yep, I think both warnings are correct. Looks like changing from a dequeue- enqueue model to in-place list mangling just broke a bunch of assumptions I'd made in earlier versions of the patches. Fixes coming soon.
Thanks, -Ed -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
