On 4/17/19 2:17 AM, Florian Westphal wrote:
setting net.netfilter.nf_conntrack_timestamp=1 breaks xmit with fq
scheduler. skb->tstamp might be "refreshed" using ktime_get_real(),
but fq expects CLOCK_MONOTONIC.
This patch removes all places in netfilter that check/set skb->tstamp:
1. To fix the bogus "start" time seen with conntrack timestamping for
outgoing packets, never use skb->tstamp and always use current time.
2. In nfqueue and nflog, only use skb->tstamp for incoming packets,
as determined by current hook (prerouting, input, forward).
3. xt_time has to use system clock as well rather than skb->tstamp.
We could still use skb->tstamp for prerouting/input/foward, but
I see no advantage to make this conditional.
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
Cc: Eric Dumazet <eduma...@google.com>
Reported-by: Michal Soltys <sol...@ziu.info>
Signed-off-by: Florian Westphal <f...@strlen.de>
Thanks for quick patch.
Applied it on top of 5.0.8 - wanted to confirm everything seems to be
working fine (and timestamps are correct).
