On Fri, May 17, 2019 at 10:17:56PM +0200, Phil Sutter wrote: > This is basically identical to the RFC sent earlier. The only change is > in second patch: As suggested by Eric, 'traceback' module is standard so > there's no need to import it conditionally. > > The schema is still in its minimalistic form, I decided to extend it in > follow-up patches.
I'm fine with this JSON validation, if no objections I'll push this out. Only one thing: I think it would be good if -s checks for -j in nft-test.py, but not a deal breaker: this can be done in a follow up patch. Thanks. > Changes since v1: > - Fix patch 2 commit message, thanks to Jones Desougi who reported the > inconsistency. > > Phil Sutter (2): > py: Implement JSON validation in nftables module > tests/py: Support JSON validation > > py/Makefile.am | 2 +- > py/nftables.py | 30 ++++++++++++++++++++++++++++++ > py/schema.json | 17 +++++++++++++++++ > py/setup.py | 1 + > tests/py/nft-test.py | 21 ++++++++++++++++++++- > 5 files changed, 69 insertions(+), 2 deletions(-) > create mode 100644 py/schema.json > > -- > 2.21.0 >
