Hi Phil, On Mon, Jun 17, 2019 at 06:00:30PM +0200, Phil Sutter wrote: > Hi, > > On Mon, Jun 17, 2019 at 02:25:15PM +0200, Pablo Neira Ayuso wrote: > > This test invokes the 'replace rule ... handle 2' command. However, > > there are no rules in the kernel, therefore it always fails. > > This guesses the previously inserted rule's handle. Does this start > failing with your flags conversion in place?
Yes. > My initial implementation of intra-transaction rule references made > this handle guessing impossible, but your single point cache > fetching still allowed for it (hence why I dropped my patch with a > similar change). Hm. I think we should not guess the handle that the kernel assigns. In a batch, handles do not exist. We could expose the intra-transaction index if needed to the user. But I don't see a use-case for this. I think we should leave the handle as a reference to already existing rules in the kernel.
