Hi, On Wed, Jul 17, 2019 at 08:35:15PM +0200, Pablo Neira Ayuso wrote: [...] > Please, use (2, "nat") instead like in other extensions. > > MODULE_ALIAS_NFT_CHAIN(2, "nat"); /* NFPROTO_INET */
I sent a non-RFC patch which uses fixed value 1. Thanks for the suggestion! > Yes, it's not nice, but this is so far what we have. > > I agree we should fix this, problem is that NFPROTO_* are enum, and > IIRC this doesn't mix well with the existing macros. Ah, right. The __stringify() thing bites us then. In order to use NFPROTO_* names, those would have to be redefined as macro. And not just like netinet/in.h does for IPPROTO_* names but with actual value. Cheers, Phil
