Michal Kubecek <mkube...@suse.cz> wrote:
> Hello,
>
> to clean up some skeletons in the closet of our distribution kernels,
> I'm trying to add a userspace conntrack helper for SLP into conntrackd.
>
> A helper is needed to handle SLP queries which are sent as multicast UDP
> packets but replied to with unicast packets so that reply's source
> address does not much request's destination. This is exactly the same
> problem as for mDNS so that I started by copying existing mdns helper in
> conntrackd and changing the default timeout. But I found that it does
> not work with 5.2 kernel.
>
> The setup looks like this (omitting some log rules):
>
> nfct helper add slp inet udp
> iptables -t raw -A OUTPUT -m addrtype --dst-type MULTICAST \
> -p udp --dport 427 -j CT --helper slp
> iptables -t raw -A OUTPUT -m addrtype --dst-type BROADCAST
> -p udp --dport 427 -j CT --helper slp
> iptables -A INPUT -i lo -j ACCEPT
> iptables -A INPUT -p tcp --dport 22 -j ACCEPT
> iptables -A INPUT -m conntrack --ctstate ESTABLISHED -j ACCEPT
> iptables -A INPUT -m conntrack --ctstate RELATED -j ACCEPT
> iptables -P INPUT DROP
> iptables -P OUTPUT ACCEPT
>
> The helper rules apply, outgoing multicast packet is sent away but the
> unicast reply is not recognized as related and rejected. Monitring with
> "conntrack -E expect" shows that an expectation is created but it is
> immediately destroyed and "conntrack -E" does not show the conntrack for
> the original multicast packet (which is created when I omit the helper
> rules in raw table). Kernel side tracing confirms that the conntrack is
> never confirmed and inserted into the hash table so that the expectation
> is destroyed once the request packet is sent out (and skb_consume()-ed).
>
> I added some more tracing and this is what seems to happen:
>
> - ipv4_confirm() is called for the conntrack from ip_output() via hook
> - nf_confirm() calls attached helper and calls its help() function
> which is nfnl_userspace_cthelper(), that returns 0x78003
> - nf_confirm() returns that without calling nf_confirm_conntrack()
> - verdict 0x78003 is returned to nf_hook_slow() which therefore calls
> nf_queue() to pass this to userspace helper on queue 7
> - nf_queue() returns 0 which is also returned by nf_hook_slow()
> - the packet reappears in nf_reinject() where it passes through
> nf_reroute() and nf_iterate() to the main switch statement
> - it takes NF_ACCEPT branch to call okfn which is ip_finish_output()
> - unless I missed something, there is nothing that could confirm the
> conntrack after that
I broke this with
commit 827318feb69cb07ed58bb9b9dd6c2eaa81a116ad
("netfilter: conntrack: remove helper hook again").
Seems we have to revert, i see no other solution at this time.
