On Sat, Jul 20, 2019 at 09:29:18PM +0200, Florian Westphal wrote: > Phil Sutter <p...@nwl.cc> wrote: > > Change xtables_save_main to support optional printing of COMMIT line as > > it is not used in arp- or ebtables. > > Why? Is this so ebt-save dumps are compatible with the > old ebt-restore?
Hmm. I haven't considered deviating in ebtables-nft-save format from legacy one yet, but it may actually be no problem given that people shouldn't switch between both. The only bummer might be if someone has a custom script which then trips over the unknown non-comment line. I'm undecided, but not against "breaking" with legacy save dumps per se. If you think it's not a problem, we could just simplify things. OTOH this is not a big patch, either so maybe not even worth the risk. :) Thanks, Phil
