Since they are generated, one has to specify them in CLEANFILES. While
being at it, introduce a variable holding them to improve readability a
bit.

Fixes: 3dfb01cf14d72 ("doc: Install ip{6,}tables-restore-translate.8 man pages")
Signed-off-by: Phil Sutter <p...@nwl.cc>
---
 iptables/Makefile.am | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/iptables/Makefile.am b/iptables/Makefile.am
index 21ac7f08b7c1f..da07b9a4b5a2f 100644
--- a/iptables/Makefile.am
+++ b/iptables/Makefile.am
@@ -47,6 +47,9 @@ xtables_nft_multi_SOURCES += xshared.c
 xtables_nft_multi_LDADD   += ../libxtables/libxtables.la -lm
 endif
 
+XTABLES_XLATE_8_LINKS = iptables-translate.8 ip6tables-translate.8 \
+                       iptables-restore-translate.8 
ip6tables-restore-translate.8
+
 sbin_PROGRAMS    = xtables-legacy-multi
 if ENABLE_NFTABLES
 sbin_PROGRAMS  += xtables-nft-multi
@@ -56,14 +59,13 @@ man_MANS         = iptables.8 iptables-restore.8 
iptables-save.8 \
                    ip6tables-save.8 iptables-extensions.8
 if ENABLE_NFTABLES
 man_MANS       += xtables-nft.8 xtables-translate.8 xtables-legacy.8 \
-                   iptables-translate.8 ip6tables-translate.8 \
-                  iptables-restore-translate.8 ip6tables-restore-translate.8 \
+                   ${XTABLES_XLATE_8_LINKS} \
                    xtables-monitor.8 \
                    arptables-nft.8 arptables-nft-restore.8 
arptables-nft-save.8 \
                    ebtables-nft.8
 endif
 CLEANFILES       = iptables.8 xtables-monitor.8 \
-                  iptables-translate.8 ip6tables-translate.8
+                  ${XTABLES_XLATE_8_LINKS}
 
 vx_bin_links   = iptables-xml
 if ENABLE_IPV4
@@ -93,7 +95,7 @@ iptables-extensions.8: iptables-extensions.8.tmpl 
../extensions/matches.man ../e
                -e '/@MATCH@/ r ../extensions/matches.man' \
                -e '/@TARGET@/ r ../extensions/targets.man' $< >$@;
 
-iptables-translate.8 ip6tables-translate.8 iptables-restore-translate.8 
ip6tables-restore-translate.8:
+${XTABLES_XLATE_8_LINKS}:
        ${AM_VERBOSE_GEN} echo '.so man8/xtables-translate.8' >$@
 
 pkgconfig_DATA = xtables.pc
-- 
2.22.0

Reply via email to