Hi Jeremy, Thank you for the patch! Yet something to improve:
[auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Jeremy-Sowden/Add-config-option-checks-to-netfilter-headers/20190902-050403 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master config: x86_64-fedora-25 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): net/netfilter/nft_chain_filter.c: In function 'nft_do_chain_bridge': >> net/netfilter/nft_chain_filter.c:208:3: error: implicit declaration of >> function 'nft_set_pktinfo_ipv4_validate'; did you mean >> 'nft_set_pktinfo_unspec'? [-Werror=implicit-function-declaration] nft_set_pktinfo_ipv4_validate(&pkt, skb); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ nft_set_pktinfo_unspec cc1: some warnings being treated as errors vim +208 net/netfilter/nft_chain_filter.c 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 195 dfee0e99bcff718 Arnd Bergmann 2019-07-10 196 #if IS_ENABLED(CONFIG_NF_TABLES_BRIDGE) 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 197 static unsigned int 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 198 nft_do_chain_bridge(void *priv, 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 199 struct sk_buff *skb, 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 200 const struct nf_hook_state *state) 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 201 { 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 202 struct nft_pktinfo pkt; 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 203 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 204 nft_set_pktinfo(&pkt, skb, state); 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 205 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 206 switch (eth_hdr(skb)->h_proto) { 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 207 case htons(ETH_P_IP): 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 @208 nft_set_pktinfo_ipv4_validate(&pkt, skb); 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 209 break; db0cf6af19b955a Jeremy Sowden 2019-09-01 210 #ifdef CONFIG_NF_TABLES_IPV6 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 211 case htons(ETH_P_IPV6): 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 212 nft_set_pktinfo_ipv6_validate(&pkt, skb); 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 213 break; db0cf6af19b955a Jeremy Sowden 2019-09-01 214 #endif 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 215 default: 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 216 nft_set_pktinfo_unspec(&pkt, skb); 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 217 break; 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 218 } 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 219 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 220 return nft_do_chain(&pkt, priv); 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 221 } 02c7b25e5f54321 Pablo Neira Ayuso 2018-03-27 222 :::::: The code at line 208 was first introduced by commit :::::: 02c7b25e5f54321b9063e18d4f52cce07f8e081d netfilter: nf_tables: build-in filter chain type :::::: TO: Pablo Neira Ayuso <pa...@netfilter.org> :::::: CC: Pablo Neira Ayuso <pa...@netfilter.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
