Hi Phil,
I am sending a v2 with an explanation. Thanks!
On 9/4/19 8:58 AM, Phil Sutter wrote:
> Hi Fernando,
>
> On Tue, Sep 03, 2019 at 11:33:13PM +0200, Fernando Fernandez Mancera wrote:
>> Fixes: d62d0ba97b58 ("netfilter: nf_tables: Introduce stateful object update
>> operation")
>> Signed-off-by: Fernando Fernandez Mancera <ffmanc...@riseup.net>
>
> Your patch looks good but please (always) provide a bit of explanation.
> In this case typical questions to answer in commit message are:
> - Why may obj->ops->update be NULL? For which object type are they not
> defined?
> - How could one trigger the issue? In other words, why is
> nft_obj_commit_update() called for the "wrong" object?
>
> Cheers, Phil
>
