Hi! On Fri, Sep 13, 2019 at 10:53:44PM +0200, Florian Westphal wrote: > Phil Sutter <p...@nwl.cc> wrote: > > Size value passed to constant_expr_alloc() must correspond with actual > > data size, otherwise wrong portion of data will be taken later when > > serializing into netlink message. > > > > Booleans require really just a bit, but make type of boolean_keys be > > uint8_t (introducing new 'val8' name for it) and pass the data length > > using sizeof() to avoid any magic numbers. > > > > While being at it, fix len value in parser_json.c as well although it > > worked before due to the value being rounded up to the next multiple of > > 8. > > Looks good, thanks Phil.
So that's an ACK? :) Cheers, Phil
