On Fri, Oct 18, 2019 at 12:48:31AM +0200, Phil Sutter wrote: > The same piece of code appears three times, introduce a function to take > care of tokenizing and error reporting. > > Pass buffer pointer via reference so it can be updated to point to after > the counters (if found). > > While being at it, drop pointless casting when passing pcnt/bcnt to > add_argv(). > > Signed-off-by: Phil Sutter <p...@nwl.cc>
Acked-by: Pablo Neira Ayuso <pa...@netfilter.org> If you get to consolidate more common code between xml and native parsers, probably you can add a xtables-restore.c file to store all these functions are common, just an idea for the future.
