Dear all,
I understood from the chairs that draft-ietf-netmod-yang-json is now
ready and that the write-up will be completed end of this week.
In order to speed up the publication, here is my AD review.
- Editorial:
This document defines encoding rules for representing configuration,
state data, RPC operation or action input and output parameters, and
notifications defined using YANG as JavaScript Object Notation (JSON)
text.
"RPC operation or action input and output parameters"
", or ... and, " it's always complicated.
Why not only "RPC operation or action"?
At the very minimum "input and output parameters" to "input/output
parameters"
Same remark for section 1.1
The specification of YANG 1.1 data modelling language
[I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-json-06#ref-I-D.ietf-netmod-rfc6020bis>] defines only XML encoding for data
instances, i.e., contents of configuration datastores, state data,
RPC operation or action input and output parameters, and event
notifications.
If you want to extend, also fine.
The specification of YANG 1.1 data modelling language
[I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-json-06#ref-I-D.ietf-netmod-rfc6020bis>] defines only XML encoding for data
instances, i.e., contents of configuration datastores, state data,
RPC operation input and output parameters, action input and output
parameters, and event notifications.
Btw, "RPC", "action" and "input and output parameters" are only
mentioned in the abstract and this introduction, not anymore in the body
of the document. There is nothing specific to these worth noting? Not
even an example?
- Editorial
In the introduction, you might want to complete the last sentence
NEW:
The specification of YANG 1.1 data modelling language
[I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-json-07#ref-I-D.ietf-netmod-rfc6020bis>] defines only XML encoding for data
instances, i.e., contents of configuration datastores, state data,
RPC operation or action input and output parameters, and event
notifications. The aim of this document is to define rules for
encoding the same data as JavaScript Object Notation (JSON)
text [RFC7159 <https://tools.ietf.org/html/rfc7159>].
NEW:
The specification of YANG 1.1 data modelling language
[I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-json-07#ref-I-D.ietf-netmod-rfc6020bis>] defines only XML encoding for data
instances, i.e., contents of configuration datastores, state data,
RPC operation or action input and output parameters, and event
notifications. The aim of this document is to define rules for
encoding the same data as JavaScript Object Notation (JSON)
text [RFC7159 <https://tools.ietf.org/html/rfc7159>], most precisely the
Internet JSON (I-JSON) restricted
profile [RFC7493 <https://tools.ietf.org/html/rfc7493>].
-
section 2:
The following terms are defined in [I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-json-07#ref-I-D.ietf-netmod-rfc6020bis>]:
...
o identity,
There is no identity definition in the RFC 6020 terminology section.
Are you referring to the identity statement,
https://tools.ietf.org/html/draft-ietf-netmod-rfc6020bis-09#section-7.18 ?
- Editorial.
OLD:
An object member name MUST be in one of the following forms:
NEW:
A JSON object member name MUST be encoded in one of the following forms:
-
module foomod {
namespace"http://example.com/foomod";
prefix "foo";
container top {
leaf foo {
type uint8;
}
}
}
Use "example-" in the module name, as mentioned
inhttps://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-05:
Example modules are non-normative, and SHOULD be named with the
prefix "example-".
Same remark for module barmod (and btw, pay attention to the "import
foomod") and module exmod
- Editorial (Appendix A):
OLD:
The "if-mib" feature defined in the "ietf-
interfaces" module is considered to be active.
NEW:
The "if-mib" feature defined in the "ietf-
interfaces" module is supported.
Regards, Benoit
_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod