Hello,

On 04/06/2017 07:43 PM, Andy Bierman wrote:

3) identity ethSubInterface

This identity is used in the encapsulation container when-stmt.
It is not clear if this is intended as a base identity (like identity sub-interface)
An example for the encapsulation container would help clarify the
expected usage

This also has 2 bases (sub-interface and l2vlan).
Some explanation in the identity-stmt would be helpful
(since this is a new YANG 1.1 construct)
It seems the intentended result was identity similar to ianaift:atmSubInterface (thus the naming convention change ethSubInterface instead of eth-sub-interface). I think it is less confusing to name the identity with the same naming convention used for the rest of the identities introduced e.g. sub-interface, loopback-internal etc. and if needed define new atm-sub-interface based on sub-interface. I am not sure even atm users would like a model where atmSubInterface will be the only identity of all future sub interface based identities not being derived from sub-interface because of this precedent:

     augment "/if:interfaces/if:interface" {
       when "derived-from(if:type,
                          'ietf-if-cmn',
                          'sub-interface') or
             if:type = 'ianaift:atmSubInterface' or
             if:type = 'ianaift:frameRelay'"  {

Vladimir


Andy


_______________________________________________
netmod mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/netmod

Reply via email to