Hi Clyde, On Thu, Mar 8, 2018, at 9:28 PM, Clyde Wildes (cwildes) wrote: > Alexey, > > Your minor comments are addressed below… > > On 3/6/18, 12:06 PM, "Alexey Melnikov" <aamelni...@fastmail.fm> wrote: > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Thank you for this document. > > I also prefer for TCP to be documented, if used in real world. > > Some minor comments:
> 2) On page 19: > > Example: compare->equals and action->no-match means > messages that have a severity that is not equal to the > specified severity will be logged."; > > Do you mean "action->block" instead of "action->no-match"? > > [clw] An equals compare with action no-match means log the message, not > block it. Your document only talks about "action->no-match" in one place in the example. Has terminology changes over years and you forgot to update the example? It is possible I am confused here. > > 3) When logging to file: how is the file name constructed from the > name file: > URI if multiple files are preserved by the system? E.g. if the log > file is > rotated daily and 5 last files are preserved, how does each > individual filename > look? If I understood how this is used, this needs more > clarification. > > [clw] We decided to leave this for the implementer as file systems may > be different for different implementations. I think you should clarify in the document what is the purpose of filename and say something about the above. I appreciate that this might not be needed for interoperability, but what you have in the document doesn't provide enough details to implement this aspect. Even saying that implementations can derive log specific filenames from the base one instead of saying nothing would be better. Thank you, Alexey _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod
