Hi Kent, authors, I’ve reviewed the latest version of the document, sorry for the delay.
I think that the changes look good, but I wonder whether a bit more description is needed for the example in the appendix, otherwise, I fear it may still be slightly confusing. (i) It may be worth including a copy of the contents of the system datastore to make it clear which configuration is present in the system datastore and hence if deleted from the running datastore will still be present in the intended datastore. E.g., “The client may also subsequently delete any copied "user-group" entries or the entire "user-groups" container, but this will not prevent the configuration as shown in Figure 2<https://www.ietf.org/archive/id/draft-ietf-netmod-immutable-flag-04.html#example> being present in <intended> (if implemented).” This will surely depend on whether the power-users group is also in the system datastore. E.g., these entries may just be in running and hence could just be deleted as normal, and not appear in intended? (ii) The example includes a hardcoded admin username/password that cannot be changed. I’m wondering whether that is really a good example to give in an IETF document, or at least flag that this is not best practice and is only be used to illustrate the hierarchical nature of the immutable flag. (iii) Similarly, the text for B.3, indicates that the tags for the power users can be removed, but would still turn up in intended. I assume that this would depend on whether those entries are also in the system datastore? Last minor comment. In section 4.1, it states “4.1., “nor is there any way to delete the node from the combined configuration (as described in [I-D.ietf-netmod-system-config<https://www.ietf.org/archive/id/draft-ietf-netmod-immutable-flag-04.html#I-D.ietf-netmod-system-config>]).” But the system-config draft doesn’t seem to mention the word combined at all. Perhaps relate back to the intended datastore (if implemented) and perhaps update the reference to the specific section where it describes the merging of configuration along with the diagram in the system datastore draft. E.g., “nor is there any way to delete the node from the combined configuration in the intended datastore (as described in [I-D.ietf-netmod-system-config<https://www.ietf.org/archive/id/draft-ietf-netmod-immutable-flag-04.html#I-D.ietf-netmod-system-config>] section XXX).” Kind regards, Rob From: Kent Watsen <kent+i...@watsen.net> Date: Wednesday, 2 July 2025 at 15:32 To: Rob Wilton (rwilton) <rwil...@cisco.com>, Jason Sterne (Nokia) <jason.ste...@nokia.com> Cc: netmod@ietf.org <netmod@ietf.org> Subject: Re: [netmod] I-D Action: draft-ietf-netmod-immutable-flag-04.txt Rob/Jason, Can you confirm the updates are good? I wish to successfully-close the WGLC now. Thanks, Kent > On Jun 11, 2025, at 11:43 AM, Kent Watsen <k...@watsen.net> wrote: > > Hi Qiufang, I have looked through the diffs and all seems good now (sans the > nit below). > > Nit: one example shows an unencrypted password, i.e., beginning with "$0$. > The "ianach:crypt-hash" type should always return a hashed password. > > Rob/Jason - are the updates okay with you as well? > > Kent > > > > > > >> On May 15, 2025, at 3:49 AM, maqiufang (A) >> <maqiufang1=40huawei....@dmarc.ietf.org> wrote: >> >> Hi, all, >> >> -04 is available now, which addresses the 2nd WGLC comments from Kent, >> Jason, and Rob (thanks a lot for your valuable comments!). >> >> The primary revisions are concentrated in section 5 (i.e., Use of Immutable >> Flag for Different Statements), alongside the incorporation of examples of >> immutability of list/leaf-list as shown in Appendix B. Both parts might >> benefit from further review from the WG to ensure agreement is clearly >> documented. There are also some other updates as suggested by reviewers. >> Would appreciate any other comments and suggestions from the WG. Thanks a >> lot! >> >> Best Regards, >> Qiufang >> >> -----Original Message----- >> From: internet-dra...@ietf.org [mailto:internet-dra...@ietf.org] >> Sent: Thursday, May 15, 2025 3:40 PM >> To: i-d-annou...@ietf.org >> Cc: netmod@ietf.org >> Subject: [netmod] I-D Action: draft-ietf-netmod-immutable-flag-04.txt >> >> Internet-Draft draft-ietf-netmod-immutable-flag-04.txt is now available. It >> is a work item of the Network Modeling (NETMOD) WG of the IETF. >> >> Title: YANG Metadata Annotation for Immutable Flag >> Authors: Qiufang Ma >> Qin Wu >> Balazs Lengyel >> Hongwei Li >> Name: draft-ietf-netmod-immutable-flag-04.txt >> Pages: 24 >> Dates: 2025-05-15 >> >> Abstract: >> >> This document defines a way to formally document an existing >> behavior, implemented by servers in production, on the immutability >> of some system-provided nodes, using a YANG metadata annotation >> called "immutable" to flag which nodes are immutable. >> >> Clients may use "immutable" annotations provided by the server, to >> know beforehand why certain otherwise valid configuration requests >> will cause the server to return an error. >> >> The immutable flag is descriptive, documenting an existing behavior, >> not proscriptive, dictating server behaviors. >> >> This document updates RFC 8040 and RFC 8526. >> >> The IETF datatracker status page for this Internet-Draft is: >> https://datatracker.ietf.org/doc/draft-ietf-netmod-immutable-flag/ >> >> There is also an HTML version available at: >> https://www.ietf.org/archive/id/draft-ietf-netmod-immutable-flag-04.html >> >> A diff from the previous version is available at: >> https://author-tools.ietf.org/iddiff?url2=draft-ietf-netmod-immutable-flag-04 >> >> Internet-Drafts are also available by rsync at: >> rsync.ietf.org::internet-drafts >> >> >> _______________________________________________ >> netmod mailing list -- netmod@ietf.org >> To unsubscribe send an email to netmod-le...@ietf.org >> _______________________________________________ >> netmod mailing list -- netmod@ietf.org >> To unsubscribe send an email to netmod-le...@ietf.org > > _______________________________________________ > netmod mailing list -- netmod@ietf.org > To unsubscribe send an email to netmod-le...@ietf.org
_______________________________________________ netmod mailing list -- netmod@ietf.org To unsubscribe send an email to netmod-le...@ietf.org
