Thanks, Michal. I’ve had a read, and I appreciate that you addressed many of my comments. I still have a few issues, though. Most of these are process-centric vs. any real technical issue with the material. There are also several grammar nits, but I didn’t list them out here. They likely will get caught in other reviews, or I can do some direct commits to the repo if you want.
Section 10.2 OLD: This document register one URI in the "ns" subregistry of the IETF XML Registry [RFC3688] maintained at https://www.iana.org/assignments/xml-registry/xml-registry.xhtml#ns. Following the format in [RFC3688], the following registration is requested: URI: urn:ietf:params:xml:ns:yang:ietf-yang-schema-comparison Registrant Contact: The IESG. XML: N/A, the requested URI is an XML namespace. NEW: This document registers two URIs in the "ns" subregistry of the IETF XML Registry [RFC3688] maintained at https://www.iana.org/assignments/xml-registry/xml-registry.xhtml#ns. Following the format in [RFC3688], the following registrations are requested: URI: urn:ietf:params:xml:ns:yang:ietf-yang-schema-comparison Registrant Contact: The IESG. XML: N/A, the requested URI is an XML namespace. URI: urn:ietf:params:xml:ns:yang:ietf-yang-schema-comparison-output Registrant Contact: The IESG. XML: N/A, the requested URI is an XML namespace. Appendix B.1 OLD: { "ietf-yang-schema-comparison:schema-comparison": { "schema": [ NEW: { "ietf-yang-schema-comparison-output:schema-comparison": { "schema": [ Section 9: OLD: The YANG module specified in this document defines a schema for data that is designed to be used by offline tooling to generate output for differences in supplied YANG modules. NEW: The YANG modules specified in this document define extensions ("ietf-yang-schema-comparison") and a schema for data ("ietf-yang-schema-comparison-output") that are designed to be used by offline tooling to generate output describing the differences between supplied YANG modules. OLD: The structure "schema-comparison" contains all the groupings reflecting the changes between YANG modules. If the data of this structure are published in online tooling, care needs to be taken so that knowledge of YANG modules is not leaked. NEW: The "schema-comparison" structure defined in the "ietf-yang-schema-comparison-output" module contains all the groupings reflecting the changes between YANG modules. If instances of this structure are published by online tooling, care needs to be taken so that information about non-public YANG modules is not inadvertently disclosed. Appendix A: OLD: YANG module with specific output of the schema comparison algorithm supporting comparison of compiled or parsed and compiled schema tree of a YANG module. The "ietf-yang-schema-comparison-output" YANG module imports definitions from the "ietf-yang-types" module defined in [RFC6991] and "ietf-yang-library" module defined in [RFC8525], and "ietf-yang-structure-ext" module defined in [RFC8791]. NEW: This YANG module defines the specific output of the schema comparison algorithm, supporting comparison of the compiled schema tree, or of both the parsed and compiled schema trees, of a YANG module. The "ietf-yang-schema-comparison-output" YANG module imports definitions from the "ietf-yang-types" module defined in [RFC6991], the "ietf-yang-library" module defined in [RFC8525], and the "ietf-yang-structure-ext" module defined in [RFC8791]. You’ve modified the type-substmts inverted leaf to have a better description and reference, but the parsed version needs some love, too. OLD: leaf inverted { type empty; description "Inverted substatement value."; } NEW: leaf inverted { type empty; description "Presence indicates that the pattern's 'modifier' substatement is 'invert-match'."; reference "RFC 7950 Section 9.4.6"; } Joe From: Michal Vasko <[email protected]> Date: Wednesday, May 27, 2026 at 05:32 To: netmod <[email protected]> Subject: [netmod] Update to draft-ietf-netmod-yang-schema-comparison Hi, a new revision of the schema-comparison draft has been published. Changes: * Added an explicit description of a parsed schema tree. * YANG module split into two, a normative (special schema-cmp extensions) and informative (algorithm output) one. * Addressed Joe Clarke's comments. Regards, Michal
_______________________________________________ netmod mailing list -- [email protected] To unsubscribe send an email to [email protected]
