On Mon, Mar 6, 2017 at 7:04 PM, Mathieu Trudel-Lapierre < [email protected]> wrote:
> Review: Needs Fixing > > These tests should be run from within autopkgtest: > > (from the netplan source tree root) > autopkgtest -U --apt-pocket=proposed -s --test-name integration.py . -- > qemu ~/adt-zesty-amd64.img > > You can build the necessary zesty qemu image for autpkgtests with: > > adt-buildvm-ubuntu-cloud -r zesty -a amd64 > Ah, thanks for that. > > This is important, my initial manual testing showed that neither networkd > nor NM devices ended up having their MTU set; so we should still test both > NM and networkd renderers to make sure that the MTU is set properly on the > underlying devices when this runs, and to properly automate testing this > behavior (given that it's reportedly playing with udev, so there are > possibly other steps to take before the changes will really be applied). > .link properties are handled by udev, not networkd. I'm not sure if NM has separate MTU handling; that may be problematic if we're delegating this to .link files for both networkd and NM. Currently 'netplan apply' does guarantee .link files are re-run. I've a separate bug opened to understand why re-triggering the net subsystem doesn't always ensure .link files are processed https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1669564 In the mean time, we could look at calling "udevadm test-builtin setup_net_link /sys/class/net/<iface>" will indeed run the rules including .link files to verify MTU is applied. > -- > https://code.launchpad.net/~raharper/netplan/+git/netplan/+merge/318545 > You are the owner of ~raharper/netplan:fix-mtu. > -- https://code.launchpad.net/~raharper/netplan/+git/netplan/+merge/318545 Your team Developers of netplan is subscribed to branch netplan:master. -- Mailing list: https://launchpad.net/~netplan-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~netplan-developers More help : https://help.launchpad.net/ListHelp
