On Tue, Apr 21, 2015 at 12:30:07PM +0200, Daniel Borkmann wrote:
> Hi Vadim,
> 
> On 04/17/2015 09:04 PM, Vadim Kochan wrote:
> >From: Vadim Kochan <vadi...@gmail.com>
> >
> >Fixed case when netsniff fails if there is already existing monX device
> >while generating.
> >
> >Signed-off-by: Vadim Kochan <vadi...@gmail.com>
> ...
> >+int device_ifindex(const char *ifname)
> >+{
> >+    int index = device_ifindex_get(ifname);
> >+    if (unlikely(index <= 0))
> 
> This test should be < 0 only as ifindex 0 would mean to
> capture on "any" device.
> 
> So starting netsniff-ng w/o any arguments would not work
> anymore otherwise, fix up:
> 
>   
> https://github.com/netsniff-ng/netsniff-ng/commit/42ca7e42aa76ee52499ae82370d11d044e811f35
> 
> >+            panic("Cannot get ifindex from device!\n");
> >+
> >+    return index;
> >+}
> 
> Cheers,
> Daniel

Fuf, thank you! And sorry for this BUG!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to