On Mon, Jul 13, 2015 at 12:31:39PM +0300, Vadim Kochan wrote: > On Mon, Jul 13, 2015 at 11:28:49AM +0200, Daniel Borkmann wrote: > > On 07/08/2015 12:20 PM, Vadim Kochan wrote: > > >From: Vadim Kochan <[email protected]> > > > > > >Added periodic (0.5s) dump of existing and visible flow to update > > >packets & bytes counters. > > >Needs to clone nf_conntrack object for new added flow entry to > > >update counters for this particular flow, instead of dump entire > > >conntrack table. Counters are showed in human readable format in SI units. > > > > > >Also added showing count of existing valid flows. > > > > > >Added new sysctl module with helpers to easy set/get value from > > >/proc/sys. > > > > I just tried out the result and I like it. With regards to the 1st sysctl > > patch, it's true that we have "/proc/<foo>" handling code spread across > > various sub-projects inside netsniff-ng. For your series, could you drop > > the 1st patch for now and integrate this directly? If later on your plan > > is to move *all* "/proc/<foo>" handling into a generic library code, I'm > > totally fine with that. In this series, it would not address other places > > however, and thus be a bit inconsistent. > > If I understood correctly, you asked to do not use separated sysctl > module unless it will not be used in other places ? But these funcs can > be used statically in flowtop.c so they then can be used later while > sysctl refactoring ? > > > > > Thanks a lot, > > Daniel
OK I squashed sysctl commit with traffic counters dump commit and will resend series v2. Thanks for review, Vadim Kochan -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
