On Tue, Dec 08, 2015 at 06:40:14PM +0100, Tobias Klauser wrote: > On 2015-12-01 at 23:04:18 +0100, Vadim Kochan <[email protected]> wrote: > > Add -D option for bpfc & trafgen to make possible pass -Dkey=value > > to C preprocessor. Characters like .?*()[]-^|`!#$&<>;\ are quoted > > to do not trick with shell's special symbols (e.g. process spawning), > > \ is ignored only if it goes before " - to make possible pass escaped > > text for trafgen's conf file. > > Please split this up into at least 4 patches to make review easier: > > 1) string list helper > 1) helpers to create/check/... argument list (cpp module) > 2) trafgen integration > 3) bpfc integration > > I'm also still not a big fan of the shell escaping solution. This adds a > lot of string handling code which needs to be reviewed _very_ carefully. > If somehow possible I'd like to avoid this alltogether. Could we maybe > get rid of the call to system() alltogether and instead use fork() + > execvp() + wait() and pass the definitions args as we got them from > getopt? You'd need to use the "-o" option to cpp instead of the input > redirection, but that should be fine... I will fork-ify it ...
-- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
