Hi, On Wed, Dec 16, 2015 at 09:34:28AM +0100, Tobias Klauser wrote: > On 2015-12-15 at 22:09:10 +0100, Vadim Kochan <[email protected]> wrote: > > Add proc_exec function which executes given process with > > argv list via fork + execvp. > > > > It allows to replace 'system' call approach which is used > > for invoking cpp and securely extend it with additional options > > like -D. > > > > Signed-off-by: Vadim Kochan <[email protected]> > > --- > > For future patch series where you send multiple version, please add a > small changelog here (below the ---) of what changed between the > versions. Otherwise it's more cumbersome to determine whether something > has changed in the patch at all and needs a new review. This means > review time will be larger for the maintainers :(
Usually I do this but I was thinking that maintainer will review the whole submitted changes, and may be this changelog might be useless ... actually I assumed that maintainer will do not trust the changelog but will go review each line again. > > For larger patch series, please also send along a cover letter (git > format-patch --cover-letter) where you give a short summary of the > overall idea of the series. In this case, adding the version changelog > to the cover letter is preferred. Really I was doing that but I observed that you responded only to each patch so I decided that may be you skip the cover letter. > > There's no need to do this for this patch series, please just keep in > mind for future patches. I'll review this series as soon as I find some > time. > > Thanks Thanks, -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
