On Fri, Jan 29, 2016 at 08:48:59AM +0100, Tobias Klauser wrote:
> On 2016-01-28 at 23:06:23 +0100, Vadim Kochan <vadi...@gmail.com> wrote:
> > Reworded commit message of 12-14 patches from series:
> >
> > "[PATCH v3 00/16] trafgen: Add proto header generation"
> >
> > 1) Added parameters & default values description.
> > 2) Functionality was not changed.
>
> Perfect, thanks a lot! Series now applied. I also took the manpage patch
> from your previous series and I'll directly fold in my few minor changes.
BTW,
1) I think that few more protocol header functions might be added (VLAN
& TCP) before release (btw when do you plan do make release ?).
2) I just realized that currently protocol functions are used at packet
compile time and checksum's will be not re-calculated if dynamic
functions (dinc,drand) changed some of the header or payload bytes.
So as future improvement it needs to add some runtime logic for
protocol fuctions. It will be needed also if to extend protocol
functions with dynamic values too, like:
{ ip(sa=192.168.1.0/24) }
{ udp(sp=2000...3000) }
really I don't know yet how to implement such syntax but this is just
for future thinking.
3) Also as I mentioned in '... Xenomai ...' thread, what about idea to
extend trfagen for altering ingress packets via protocol functions ?
So currently I see it that in ingress mode protocol functions will
change only parameters which were specified, the default will be
ignored. Again I am not sure how useful it might be.
Regards,
Vadim Kochan
--
You received this message because you are subscribed to the Google Groups
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
