On Tue, Feb 2, 2016 at 5:54 PM, Tobias Klauser <tklau...@distanz.ch> wrote:
> On 2016-02-01 at 18:01:34 +0100, Vadim Kochan <vadi...@gmail.com> wrote:
>> Add 'vlan()' function for creating VLAN header 802.1q or 802.1ad.
>> There is a tricky change which changes struct proto_field.offset
>> uint16_t -> int16_t to allow negative values which is used in VLAN
>> protocol header by using -2 offset for TPID field which overlaps with
>> ether type field.
>>
>> Additionally series has changes for simplify setting correct upper protocol
>> id by lower layer by delegating this to the lower protocol. So upper protocol
>> specifies it's proto_id to the lower protocol which decides which field &
>> value
>> to set.
>>
>> Vadim Kochan (7):
>> trafgen: proto: Simplify getting lower protocol after init
>> trafgen: proto: Add set_next_proto callback to struct proto_hdr
>> trafgen: eth: Add setting next protocol id
>> trafgen: ipv4: Add setting next protocol id
>> trafgen: l2: Add VLAN header generation
>> trafgen: parser: Add syntax for VLAN header creating
>> trafgen: man: Add help for VLAN header function
>
> Series applied, thanks Vadim!
>
> Please note that I took out the VLAN ID setting as a pure number. I
> think it is a bit inconsistent with the rest of the functions and typing
> an additional 3 characters ('id=') shouldn't hurt too much and IMO also
> helps keep the configuration fields more readable. Hope that's OK with
> you.
Well, I just was thinking that it would be good to have simple form of
adding VLAN header 'vlan(1)'
This form might relate to any small header where is some main numeric
parameter (e.g mpls).
And really I think that 'vlan(100)' is enough readable and understandable.
Regards,
Vadim Kochan
--
You received this message because you are subscribed to the Google Groups
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
