On Wed, Jan 25, 2017 at 2:24 PM, Tobias Klauser <tklau...@distanz.ch> wrote:
> On 2017-01-23 at 22:49:22 +0100, Vadim Kochan <vadi...@gmail.com> wrote:
>> While fixing the issue with getting of IPv4 address from device,
>> the setting of default src IPv4/IPv6 addresses was moved from
>> hdr->header_init(...) callback to hdr->packet_finish(...), but
>> packet_finish(...) is called in the following order:
>>
>>     udp_hdr->packet_finish() - UDP csum calculation over IPv4/6 pseudo header
>>     ip4_hdr->packet_finish() - setting default src IPv4 address from dev
>>     ...
>>
>> So src IPv4/6 address will be set after UDP/TCP csum calculation which
>> is wrong, so fixed issue by moving it to the hdr->header_init(...) stage
>> as it was before the c4e07d5142c8.
>>
>> Fixes: c4e07d5142c8 ("trafgen: l3: Support interface without IP address")
>> Signed-off-by: Vadim Kochan <vadi...@gmail.com>
>
> Applied, thanks Vadim.

BTW,
We really need some sub-folder with scapy tests to check
trafgen/mausezahn packet's generation.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to