Hi Salvatore, Your current line of thinking makes sense to me. I am doing a review of the branch, and will send out a response soon. We should try to get the unit tests merged soon and then create high priority "test stopper" bugs around API spec divergence and try to fix them as soon as possible. This way we can unblock all merges and proceed towards getting our tests fixed as first order of business.
Thanks, Somik On Wed, Jul 20, 2011 at 4:15 AM, Salvatore Orlando < salvatore.orla...@eu.citrix.com> wrote: > Hi all, **** > > ** ** > > There are currently several parts of the API implementation that are not > aligned with the specification.**** > > This happened as the specification was updated while the API was being > implemented, and therefore the API code now does not reflect the > specification.**** > > ** ** > > These issues came out while developing code for API unit tests, and Somik > has done a great job in pointing them out here:**** > > > https://code.launchpad.net/~netstack/quantum/quantum-unit-tests/+merge/68308<https://code.launchpad.net/%7Enetstack/quantum/quantum-unit-tests/+merge/68308> > **** > > ** ** > > It is my opinion that the current API specification should be reviewed in > order to:**** > > **· **Ensure it complies as much as possible with standards > adopted in the Openstack API;**** > > **· **Providing full specification for format of request/response > objects, both in JSON and XML;**** > > **· **Make sure all status codes are meaningful, and not > overlapping with HTTP specification.**** > > ** ** > > We will then need to update unit tests and API code in order to reflect > these changes. **** > > I have created a bug report to track progress on this issue on Launchpad: > https://bugs.launchpad.net/quantum/+bug/813433**** > > ** ** > > I shall start work on the API specification today. I will post on this > thread when the work is complete. In the meanwhile we should decide whether > to postpone merging branches into Quantum trunk until the API specification > review is complete. My personal opinion is that we should proceed to merge > unit tests branch and unblock the current merge queue, and give High > priority to the above mentioned bug in order to make sure relevant > adjustments, both in code and specification are agreed and applied as soon > as possible.**** > > ** ** > > Any thoughts?**** > > ** ** > > Cheers, **** > > Salvatore**** > > -- > Mailing list: https://launchpad.net/~netstack > Post to : netstack@lists.launchpad.net > Unsubscribe : https://launchpad.net/~netstack > More help : https://help.launchpad.net/ListHelp > > -- Somik Behera | Nicira Networks, Inc. | so...@nicira.com <sbeh...@nicira.com> | office: 650-390-6790 | cell: 512-577-6645
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
