On Fri, Aug 26, 2011 at 6:10 AM, Salvatore Orlando < salvatore.orla...@eu.citrix.com> wrote:
> A quick update on the current D-4 status ( > https://launchpad.net/quantum/+milestone/diablo-4) > It looks like Tyler reviewed the branch quickly this morning. Thanks Tyler! I will confirm that my comments were addressed, then merge. The diablo-4 drop doesn't have to be completely bug free, particularly since diablo-rbp is coming up so soon (9/10). To me the important thing is that diablo-4 represents the beginning of a stable point in the codebase, wherein we can focus on identifying + fixing bugs without needing to worry about additional large changes being introduced that can result in additional instability. If a bug prevents someone from performing this testing in common scenarios, it should be a blocker for diablo-4. Otherwise, it can probably be targeted for diablo-rbp. The CLI fixes issues are one obvious thing that meets that criteria. I don't believe any other bugs fall in this category, but if others are aware of an issue that is a blocker for them, please let me know (loading the plugin twice with extensions sounds bad, but I'm unaware of it being a blocker for anyone). Otherwise, let's target all bugs against diablo-rbp. Right now, there are two "feature" branches that have exceptions to drop post diablo-4: - Quantum API Auth (Keystone Integration)<https://blueprints.launchpad.net/quantum/+spec/quantum-api-auth>. Limited risk as it is not enabled by default and doesn't touch much other code. - One remaining Cisco plugin merge. Limited risk as changes affect only Cisco plugin. Despite the limited risk, we should strive to get these branches in as soon as possible. Other than that, all future changes should be focused on fixing bugs targeted for diablo-rbp or adding test coverage. During the diablo-rbp period, use you own judgement about whether a bug needs to be targeted for the diablo-rbp release. As the diablo-rbp release gets closer, we can send out an emails tracking any high priority bugs that have not yet been tackled. After diablo-rbp, only critical bugs should be merged, meaning there will be a discussion during the merge prop process about the risk/reward of each bugfix. dan > **** > > ** ** > > Blueprints: **** > > ** ** > > Quantum API v1.0 > Implementation<https://blueprints.launchpad.net/quantum/+spec/quantum-api-v1> > Essential Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Implemented **** > > Nova: Create Quantum > Manager<https://blueprints.launchpad.net/quantum/+spec/nova-quantum-manager> > High dan wendlandt<https://launchpad.net/%7Edanwent> > Needs Code Review *Code for this bp goes in nova > trunk, granted FFE***** > > Quantum Multi-Switch Plugin > Framework<https://blueprints.launchpad.net/quantum/+spec/quantum-multi-switch-plugin> > High Sumit Naiksatam<https://launchpad.net/%7Esnaiksat> > Needs Code Review *I think this bp is implemented now*** > ** > > Quantum Plugin Support for > 802.1Qbh<https://blueprints.launchpad.net/quantum/+spec/quantum-802-1qbh> > High Sumit Naiksatam<https://launchpad.net/%7Esnaiksat> > Needs Code Review *Can this bp be considered > “Implemented” with the latest merge?***** > > Layer 2 driver for Nexus OS-based > ...<https://blueprints.launchpad.net/quantum/+spec/quantum-nexus-switch-driver> > High Edgar Magana <https://launchpad.net/%7Eemagana> > Implemented **** > > Quantum API Extension > Framework<https://blueprints.launchpad.net/quantum/+spec/quantum-api-extensions> > High Rajaram > Mallya<https://launchpad.net/%7Erajarammallya> > Beta Available *I think this bp is > implemented now***** > > Nova: Expose > VifID<https://blueprints.launchpad.net/quantum/+spec/nova-quantum-vifid> > High Ryu Ishimoto<https://launchpad.net/%7Eryu-midokura> > Implemented **** > > Nova: Linuxnet Vif > Plugging<https://blueprints.launchpad.net/quantum/+spec/nova-linuxnet-vifplugging> > Medium dan wendlandt <https://launchpad.net/%7Edanwent> > Beta Available* I think this bp is > implemented now***** > > Quantum Client API > Library<https://blueprints.launchpad.net/quantum/+spec/quantum-client-library> > Medium Tyler Smith <https://launchpad.net/%7Etylesmit> > Beta Available *I think this bp > is implemented now* > > Quantum API Auth (Keystone > Integration)<https://blueprints.launchpad.net/quantum/+spec/quantum-api-auth> > Medium Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Needs Code Review *Approval delayed for a minor conflict > only.***** > > Unit Tests to Check Conformance to API > Spec<https://blueprints.launchpad.net/quantum/+spec/api-spec-unit-tests> > Medium Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Implemented **** > > Quantum Client > GUI<https://blueprints.launchpad.net/quantum/+spec/quantum-client-gui> > Low Mark T. > Voelker<https://launchpad.net/%7Emvoelker> > Good progress *Unsure about completion > status, but should not affect D-4 milestone* > > ** ** > > Bugs:**** > > #823398 unit tests for > batch_config.py<https://bugs.launchpad.net/bugs/823398> > Medium New > *IMHO should be retargeted to RBP.*** > > #826563 add version.py, similar to > nova<https://bugs.launchpad.net/bugs/826563> > Low > New *IMHO should be retargeted to RBP.***** > > #798262 Faulty XML deserialization > <https://bugs.launchpad.net/bugs/798262> > Critical Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > *In Progress Bug resurfaced in client library. Fix > proposed for merge.*** > > #834486 api alignment broke > cli<https://bugs.launchpad.net/bugs/834486> > Critical > Salvatore Orlando<https://launchpad.net/%7Esalvatore-orlando> > *In Progress Regression bug. Fix proposed for > merge.*** > > #823396 Unit tests for > CLI<https://bugs.launchpad.net/bugs/823396> > High > Salvatore Orlando<https://launchpad.net/%7Esalvatore-orlando> > *In Progress** Big merge proposal. More a BP than a bug > fix.***** > > #834572 PEP8 errors detected in > trunk<https://bugs.launchpad.net/bugs/834572> > High Salvatore > Orlando <https://launchpad.net/%7Esalvatore-orlando> *In > Progress** Fix (easy) proposed for merge.*** > > #819478 Enhancement to the Client Library > Packaging<https://bugs.launchpad.net/bugs/819478> > Medium Tyler Smith <https://launchpad.net/%7Etylesmit> > *In Progress Progress unknown.***** > > #813433 Align API implementation with > specifcation<https://bugs.launchpad.net/bugs/813433> > Critical Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Fix Committed **** > > #822890 Quantum project is missing any sort of > ...<https://bugs.launchpad.net/bugs/822890> > Critical Somik Behera<https://launchpad.net/%7Esomikbehera> > Fix Committed**** > > #834491 api alignment merge broke ovs > plugin<https://bugs.launchpad.net/bugs/834491> > Critical dan > wendlandt<https://launchpad.net/%7Edanwent> > Fix Committed **** > > #826001 Build failing for missing webtest > pkg<https://bugs.launchpad.net/bugs/826001> > High > Fix Committed**** > > #814518 Request body parser should reject > body...<https://bugs.launchpad.net/bugs/814518> > Low Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Fix Committed **** > > #821628 Getting network details is > failing<https://bugs.launchpad.net/bugs/821628> > Undecided Salvatore > Orlando<https://launchpad.net/%7Esalvatore-orlando> > Fix Committed**** > > ** ** > > I think all the blueprints are in good shape, and it should be very easy to > get them merge today. **** > > Unfortunately I think we should retarget two bugs #823398, and #826563. It > is a shame, but I’m afraid it’s too late.**** > > ** ** > > We have 2 Critical and 2 High bugs still in progress. While #834572 is > relatively easy (PEP8 fixes), a single branch has been proposed for fixing > the 3 remaining bugs. **** > > This branch is lp:~salvatore-orlando/quantum/quantum-cli-revised, and has a > large diff (>1K LOCs). Review is in progress, but it is not possible to > assume it will be fit for merge by the end of the day.**** > > Similarly we cannot afford to slip D-4 by another day (IMHO). **** > > For this reason I have pushed another branch, > lp:~salvatore-orlando/quantum/bug834486_798262 which contains fixes for Bug > #834486 and #798262 alone. The above mentioned branch has a much smaller > diff (65 lines); it is currently on hold for merge. **** > > ** ** > > In my opinion the plan would be to try and get > lp:~salvatore-orlando/quantum/quantum-cli-revised approved first and reject > lp:~salvatore-orlando/quantum/bug834486_798262. **** > > Should there be concerns around the CLI rework, we will merge > lp:~salvatore-orlando/quantum/bug834486_798262 only.**** > > ** ** > > Regards,**** > > Salvatore**** > > ** ** > > *From:* Sumit Naiksatam (snaiksat) [mailto:snaik...@cisco.com] > *Sent:* 26 August 2011 09:43 > *To:* Dan Wendlandt > > *Cc:* Salvatore Orlando; netstack@lists.launchpad.net > *Subject:* RE: [Netstack] D-4 drop delayed: cli appears broken in trunk*** > * > > ** ** > > Done on the first count, not on the second J…thanks for pointing it out…** > ** > > ** ** > > *From:* Dan Wendlandt [mailto:d...@nicira.com] > *Sent:* Friday, August 26, 2011 1:38 AM > *To:* Sumit Naiksatam (snaiksat) > *Cc:* Salvatore Orlando; netstack@lists.launchpad.net > *Subject:* Re: [Netstack] D-4 drop delayed: cli appears broken in trunk*** > * > > ** ** > > ** ** > > On Fri, Aug 26, 2011 at 1:32 AM, Sumit Naiksatam (snaiksat) < > snaik...@cisco.com> wrote:**** > > J I could do it, but I think someone like Tyler who has more familiarity > with the code can do a better job. On seeing this thread, I did reach out to > him and made that suggestion.**** > > ** ** > > Great. And Sumit, you can also get some brownie points (though not as > many) for reviewing the much shorter OVS plugin patch :P **** > > ** ** > > https://code.launchpad.net/~danwent/quantum/lp834491/+merge/73002**** > > ** ** > > If you haven't already, its probably worth making sure the Cisco plugin > wasn't similarly affected by the tweaked assumptions in the new API code. > **** > > ** ** > > Dan**** > > **** > > **** > > *From:* netstack-bounces+snaiksat=cisco....@lists.launchpad.net [mailto: > netstack-bounces+snaiksat=cisco....@lists.launchpad.net] *On Behalf Of > *Salvatore > Orlando > *Sent:* Friday, August 26, 2011 1:31 AM > *To:* Dan Wendlandt**** > > > *Cc:* netstack@lists.launchpad.net > *Subject:* Re: [Netstack] D-4 drop delayed: cli appears broken in trunk*** > * > > **** > > It looks Sumit is still around J**** > > **** > > *From:* Dan Wendlandt [mailto:d...@nicira.com] > *Sent:* 26 August 2011 09:23 > *To:* Salvatore Orlando > *Cc:* netstack@lists.launchpad.net > *Subject:* Re: [Netstack] D-4 drop delayed: cli appears broken in trunk*** > * > > **** > > **** > > On Fri, Aug 26, 2011 at 1:06 AM, Salvatore Orlando < > salvatore.orla...@eu.citrix.com> wrote:**** > > Sorry about the broken CLI. **** > > Without unit tests, I did some manual tests, but unfortunately it seems my > tests were not thorough enough.**** > > **** > > The revised-cli branch is already updated for API v1.0, and has unit tests > which pass. **** > > As stated by Dan, a first review has already been done, and I’m addressing > his comments. I’m quite confident we can get it merged today.**** > > **** > > Its a race to see how can get review #2 done.... lots of brownie points to > the winner! :) **** > > **** > > **** > > Regards,**** > > Salvatore**** > > **** > > *From:* netstack-bounces+salvatore.orlando= > eu.citrix....@lists.launchpad.net [mailto: > netstack-bounces+salvatore.orlando=eu.citrix....@lists.launchpad.net] *On > Behalf Of *Dan Wendlandt > *Sent:* 26 August 2011 08:23 > *To:* netstack@lists.launchpad.net > *Subject:* [Netstack] D-4 drop delayed: cli appears broken in trunk**** > > **** > > Hi folks,**** > > **** > > Great work on all of the reviews folks. **** > > **** > > Unfortunately, with the flurry of activity, it seems like latest API > changes seem to have broken the cli in trunk. Since the CLI is currently > the main way an outsider would currently play with Quantum, it probably > doesn't make much sense to create a D-4 drop were someone cannot perform > basic operations like creating a network. **** > > **** > > We could fix the current cli.py (the problems seem to be fairly simple > parameter renames), but I feel a better approach is probably just to quickly > review Salvatore's new CLI branch that is based on cheetah templates, as > that branch has unit tests that would have detected this issue in the first > place. I have done a first review, but it would be great if at least one > other person could take a look at this sometime on friday so we can get the > code merged: > https://code.launchpad.net/~salvatore-orlando/quantum/quantum-cli-revised/+merge/72934 > **** > > **** > > Thanks!**** > > **** > > Dan**** > > **** > > **** > > > **** > > **** > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks, Inc. > www.nicira.com | www.openvswitch.org > Sr. Product Manager > cell: 650-906-2650 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~**** > > > > **** > > **** > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks, Inc. > www.nicira.com | www.openvswitch.org > Sr. Product Manager > cell: 650-906-2650 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~**** > > > > **** > > ** ** > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks, Inc. > www.nicira.com | www.openvswitch.org > Sr. Product Manager > cell: 650-906-2650 > ~~~~~~~~~~~~~~~~~~~~~~~~~~~**** > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. www.nicira.com | www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : netstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
