Hi,
I can do some if you guys wish.
Thanks
Gary
On 06/16/2012 07:54 PM, Juliano Martinez wrote:
Sumit,
Follow the list of files that need to be fixed:
quantum/plugins/cisco/db/l2network_db.py
quantum/plugins/cisco/db/l2network_models.py
quantum/plugins/cisco/db/models.py
quantum/plugins/cisco/db/nexus_db.py
quantum/plugins/cisco/db/nexus_models.py
quantum/plugins/cisco/db/services_db.py
quantum/plugins/cisco/db/services_models.py
quantum/plugins/cisco/db/ucs_db.py
quantum/plugins/cisco/db/ucs_models.py
quantum/plugins/cisco/l2network_plugin.py
quantum/plugins/cisco/models/l2network_single_blade.py
quantum/plugins/cisco/nova/quantum_port_aware_scheduler.py
quantum/plugins/cisco/nova/vifdirect.py
quantum/plugins/cisco/segmentation/l2network_vlan_mgr.py
quantum/plugins/cisco/services/service_insertion.py
quantum/plugins/cisco/tests/unit/test_cisco_extension.py
quantum/plugins/cisco/tests/unit/test_database.py
quantum/plugins/cisco/tests/unit/test_l2networkApi.py
quantum/plugins/cisco/tests/unit/test_l2network_multi_blade.py
quantum/plugins/cisco/tests/unit/test_ucs_driver.py
quantum/plugins/cisco/tests/unit/test_vlan_mgr.py
quantum/plugins/cisco/ucs/cisco_ucs_inventory.py
quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py
quantum/plugins/cisco/ucs/cisco_ucs_plugin.py
quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py
quantum/plugins/linuxbridge/common/utils.py
quantum/plugins/linuxbridge/db/l2network_db.py
quantum/plugins/linuxbridge/LinuxBridgePlugin.py
quantum/plugins/linuxbridge/tests/unit/_test_linuxbridgeAgent.py
If you want to split the job, just tell which slice I should do :D.
[]'s
Juliano Martinez
On Saturday, June 16, 2012 at 1:46 PM, Sumit Naiksatam (snaiksat) wrote:
I am working on some of these, thanks for the heads up.
~Sumit.
------------------------------------------------------------------------
*From:* netstack-bounces+snaiksat=cisco....@lists.launchpad.net
<mailto:cisco....@lists.launchpad.net>
[netstack-bounces+snaiksat=cisco....@lists.launchpad.net
<mailto:cisco....@lists.launchpad.net>] on behalf of Dan Wendlandt
[d...@nicira.com <mailto:d...@nicira.com>]
*Sent:* Saturday, June 16, 2012 9:13 AM
*To:* Robert Kukura
*Cc:* netstack@lists.launchpad.net <mailto:netstack@lists.launchpad.net>
*Subject:* Re: [Netstack] pep8
Yes, pep8 seems to be revving their versions quite frequently :)
The current strategy, discussed on the list, is that we'll roll with
the punches and just fix the new issues as pep8 flags them. This
encourages us to keep improving the style-quality of the code base.
In this case, pep8 started flagging indentation errors, and there
are a lot of them.
Juliano has started fixes the errors in a review (he handled 33 out
of 91 files): https://review.openstack.org/#/c/8632/
Unfortunately, Jenkins will only take a patch that is passing the
gate, which includes pep8, so all the change will need to go in a
single patch-set.
I've updated Juliano's branch to fix another big chunk of files. Now
(I believe) the only thing that remains is cleaning up the Cisco UCS
and linuxbridge plugins.
To whoever volunteers to fix those, just pull the branch using the
URL on the review page, make your improvements, amend the existing
commit, and run "git review". As long as the Change-Id in the commit
isn't modified, you should be able to push to the review that Juliano
started, just like I did. Once all of the pep8 errors are handled,
Jenkins should give the change-set a +1, and we can merge.
Dan
On Fri, Jun 15, 2012 at 12:00 PM, Robert Kukura <rkuk...@redhat.com
<mailto:rkuk...@redhat.com>> wrote:
Dan,
I'm getting lots of pep8 errors lately, as shown at the end of this
email, when running tox in the quantum master branch. I suspect this
commit might be related:
commit 88deb9f4eb1bfa8d0e1543d53c598e09f4e5cfd8
Author: Dan Wendlandt <d...@nicira.com <mailto:d...@nicira.com>>
Date: Wed Jun 6 12:41:13 2012 -0700
Remove hardcoded version for pep8 from tools/test-requires
In email discussions we decided that the master branch should always
pull in the lastest version of the pep8 tool, which keeps us closest
to the real pep-8 document. Therefore, I'm removing the hardcoded
version here to match the lack of a pep8 version in tox.ini (which is
what the CI infrastructure uses when running the gating pep8 checks).
Note that your pep8 version will only update when you re-run
pip install --upgrade -r tools/test-requires .
Change-Id: I242cb042cff5f5969aa50d40312f87979191c7b7
It looks like I'm getting version 1.3 of tox. Any suggestions?
Thanks,
-Bob
[TOX] ***creating virtualenv pep8
[TOX] /home/rkukura/OpenStack/scm/quantum/.tox$ /usr/bin/python2.7
/usr/lib/python2.7/site-packages/virtualenv.py --distribute
--no-site-packages pep8 >pep8/log/0.log
[TOX] ***installing dependencies: pep8
[TOX] /home/rkukura/OpenStack/scm/quantum/.tox/pep8/log$ ../bin/pip
install
--download-cache=/home/rkukura/OpenStack/scm/quantum/.tox/_download pep8
>1.log
[TOX] ***installing sdist
[TOX] /home/rkukura/OpenStack/scm/quantum/.tox/pep8/log$ ../bin/pip
install
--download-cache=/home/rkukura/OpenStack/scm/quantum/.tox/_download
/home/rkukura/OpenStack/scm/quantum/.tox/dist/quantum-2012.2.zip >2.log
[TOX] /home/rkukura/OpenStack/scm/quantum$ .tox/pep8/bin/pep8 --repeat
--show-source --exclude=.venv,.tox,dist,doc .
./tools/install_venv.py:64:37: E127 continuation line over-indented for
visual indent
check_exit_code=False).strip())
^
./tools/install_venv.py:72:26: E127 continuation line over-indented for
visual indent
'Try installing python-virtualenv')
^
./quantum/context.py:46:21: E128 continuation line under-indented for
visual indent
str(kwargs))
^
./quantum/wsgi.py:489:41: E127 continuation line over-indented for
visual indent
RequestHeadersDeserializer()
^
./quantum/wsgi.py:770:43: E127 continuation line over-indented for
visual indent
"url": request.url})
^
./quantum/extensions/_pprofiles.py:56:17: E123 closing bracket does not
match indentation of opening bracket's line
))
^
./quantum/extensions/_pprofiles.py:63:17: E123 closing bracket does not
match indentation of opening bracket's line
))
^
./quantum/extensions/credential.py:83:9: E123 closing bracket does not
match indentation of opening bracket's line
]
^
./quantum/extensions/extensions.py:231:25: E127 continuation line
over-indented for visual indent
resource.collection)
^
...
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com <http://www.nicira.com>
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
Mailing list: https://launchpad.net/~netstack
<https://launchpad.net/%7Enetstack>
Post to : netstack@lists.launchpad.net
<mailto:netstack@lists.launchpad.net>
Unsubscribe : https://launchpad.net/~netstack
<https://launchpad.net/%7Enetstack>
More help : https://help.launchpad.net/ListHelp
--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp
