Gitweb links:

...log 
http://git.netsurf-browser.org/netsurf.git/shortlog/209d3a5ccfdaa93402a557bdf335b8ea8d325cb6
...commit 
http://git.netsurf-browser.org/netsurf.git/commit/209d3a5ccfdaa93402a557bdf335b8ea8d325cb6
...tree 
http://git.netsurf-browser.org/netsurf.git/tree/209d3a5ccfdaa93402a557bdf335b8ea8d325cb6

The branch, master has been updated
       via  209d3a5ccfdaa93402a557bdf335b8ea8d325cb6 (commit)
      from  5dadb1a0ec25d0bddb59b75969c551166c7dad86 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commitdiff 
http://git.netsurf-browser.org/netsurf.git/commitdiff/209d3a5ccfdaa93402a557bdf335b8ea8d325cb6
commit 209d3a5ccfdaa93402a557bdf335b8ea8d325cb6
Author: Michael Drake <t...@netsurf-browser.org>
Commit: Michael Drake <t...@netsurf-browser.org>

    Fix ref counting issue in named sibling selection callback.

diff --git a/css/select.c b/css/select.c
index 5c620b1..ee00412 100644
--- a/css/select.c
+++ b/css/select.c
@@ -638,9 +638,10 @@ css_error named_sibling_node(void *pw, void *node,
                dom_node_unref(n);
 
                if (dom_string_caseless_lwc_isequal(name, qname->name)) {
-                       /** \todo Sort out reference counting */
                        *sibling = n;
                }
+
+               dom_string_unref(name);
        }
 
        return CSS_OK;


-----------------------------------------------------------------------

Summary of changes:
 css/select.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/css/select.c b/css/select.c
index 5c620b1..ee00412 100644
--- a/css/select.c
+++ b/css/select.c
@@ -638,9 +638,10 @@ css_error named_sibling_node(void *pw, void *node,
                dom_node_unref(n);
 
                if (dom_string_caseless_lwc_isequal(name, qname->name)) {
-                       /** \todo Sort out reference counting */
                        *sibling = n;
                }
+
+               dom_string_unref(name);
        }
 
        return CSS_OK;


-- 
NetSurf Browser

_______________________________________________
netsurf-commits mailing list
netsurf-commits@netsurf-browser.org
http://vlists.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org

Reply via email to