Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/958fb6aa5ea5ca93c5b099633ba72ee509a47547
...commit
http://git.netsurf-browser.org/netsurf.git/commit/958fb6aa5ea5ca93c5b099633ba72ee509a47547
...tree
http://git.netsurf-browser.org/netsurf.git/tree/958fb6aa5ea5ca93c5b099633ba72ee509a47547
The branch, master has been updated
via 958fb6aa5ea5ca93c5b099633ba72ee509a47547 (commit)
from 4448fa6cbf9aade05d02f5e04b9137d4c775a79a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=958fb6aa5ea5ca93c5b099633ba72ee509a47547
commit 958fb6aa5ea5ca93c5b099633ba72ee509a47547
Author: Vincent Sanders <[email protected]>
Commit: Vincent Sanders <[email protected]>
add url databse write output to unit test
diff --git a/test/nsoption.c b/test/nsoption.c
index 0385bf9..cd1213b 100644
--- a/test/nsoption.c
+++ b/test/nsoption.c
@@ -592,7 +592,7 @@ static nserror failing_init_cb(struct nsoption_s *defaults)
}
/**
- * Test default initialisation waith failing callback
+ * Test default initialisation with failing callback
*/
START_TEST(nsoption_api_init_failcb_test)
{
diff --git a/test/urldbtest.c b/test/urldbtest.c
index 457f117..2a50dac 100644
--- a/test/urldbtest.c
+++ b/test/urldbtest.c
@@ -373,7 +373,7 @@ END_TEST
TCase *urldb_original_case_create(void)
{
TCase *tc;
- tc = tcase_create("Original urldb tests");
+ tc = tcase_create("Original_tests");
/* ensure corestrings are initialised and finalised for every test */
tcase_add_checked_fixture(tc,
@@ -388,18 +388,33 @@ TCase *urldb_original_case_create(void)
START_TEST(urldb_session_test)
{
nserror res;
+ char *outnam;
+
+ /* writing output requires options initialising */
+ res = nsoption_init(NULL, NULL, NULL);
+ ck_assert_int_eq(res, NSERROR_OK);
res = urldb_load(test_urldb_path);
ck_assert_int_eq(res, NSERROR_OK);
+ /* write database out */
+ outnam = tmpnam(NULL);
+ res = urldb_save(outnam);
+ ck_assert_int_eq(res, NSERROR_OK);
+
urldb_destroy();
+
+ /* finalise options */
+ res = nsoption_finalise(NULL, NULL);
+ ck_assert_int_eq(res, NSERROR_OK);
+
}
END_TEST
TCase *urldb_session_case_create(void)
{
TCase *tc;
- tc = tcase_create("Full session");
+ tc = tcase_create("Full_session");
/* ensure corestrings are initialised and finalised for every test */
tcase_add_checked_fixture(tc,
@@ -426,7 +441,7 @@ END_TEST
TCase *urldb_api_case_create(void)
{
TCase *tc;
- tc = tcase_create("API checks");
+ tc = tcase_create("API_checks");
tcase_add_test_raise_signal(tc,
urldb_api_add_host_assert_test,
-----------------------------------------------------------------------
Summary of changes:
test/nsoption.c | 2 +-
test/urldbtest.c | 21 ++++++++++++++++++---
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/test/nsoption.c b/test/nsoption.c
index 0385bf9..cd1213b 100644
--- a/test/nsoption.c
+++ b/test/nsoption.c
@@ -592,7 +592,7 @@ static nserror failing_init_cb(struct nsoption_s *defaults)
}
/**
- * Test default initialisation waith failing callback
+ * Test default initialisation with failing callback
*/
START_TEST(nsoption_api_init_failcb_test)
{
diff --git a/test/urldbtest.c b/test/urldbtest.c
index 457f117..2a50dac 100644
--- a/test/urldbtest.c
+++ b/test/urldbtest.c
@@ -373,7 +373,7 @@ END_TEST
TCase *urldb_original_case_create(void)
{
TCase *tc;
- tc = tcase_create("Original urldb tests");
+ tc = tcase_create("Original_tests");
/* ensure corestrings are initialised and finalised for every test */
tcase_add_checked_fixture(tc,
@@ -388,18 +388,33 @@ TCase *urldb_original_case_create(void)
START_TEST(urldb_session_test)
{
nserror res;
+ char *outnam;
+
+ /* writing output requires options initialising */
+ res = nsoption_init(NULL, NULL, NULL);
+ ck_assert_int_eq(res, NSERROR_OK);
res = urldb_load(test_urldb_path);
ck_assert_int_eq(res, NSERROR_OK);
+ /* write database out */
+ outnam = tmpnam(NULL);
+ res = urldb_save(outnam);
+ ck_assert_int_eq(res, NSERROR_OK);
+
urldb_destroy();
+
+ /* finalise options */
+ res = nsoption_finalise(NULL, NULL);
+ ck_assert_int_eq(res, NSERROR_OK);
+
}
END_TEST
TCase *urldb_session_case_create(void)
{
TCase *tc;
- tc = tcase_create("Full session");
+ tc = tcase_create("Full_session");
/* ensure corestrings are initialised and finalised for every test */
tcase_add_checked_fixture(tc,
@@ -426,7 +441,7 @@ END_TEST
TCase *urldb_api_case_create(void)
{
TCase *tc;
- tc = tcase_create("API checks");
+ tc = tcase_create("API_checks");
tcase_add_test_raise_signal(tc,
urldb_api_add_host_assert_test,
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
