Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/24c195910506e99b7d9152524aeaef042da1dedf
...commit
http://git.netsurf-browser.org/netsurf.git/commit/24c195910506e99b7d9152524aeaef042da1dedf
...tree
http://git.netsurf-browser.org/netsurf.git/tree/24c195910506e99b7d9152524aeaef042da1dedf
The branch, master has been updated
via 24c195910506e99b7d9152524aeaef042da1dedf (commit)
from 747958c14caa03f48fdd3256d63601b513ca499c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=24c195910506e99b7d9152524aeaef042da1dedf
commit 24c195910506e99b7d9152524aeaef042da1dedf
Author: Chris Young <[email protected]>
Commit: Chris Young <[email protected]>
We don't need ReplyMsg here.
TimerRequests are removed from the message queue by WaitIO() which is
ultimately called when the event is taken off the heap.
The event on the top of the heap is _not necessarily_ the one which
signalled us, though, and we should probably be handling this better.
diff --git a/frontends/amiga/schedule.c b/frontends/amiga/schedule.c
index 6b8ee8b..f6145a1 100755
--- a/frontends/amiga/schedule.c
+++ b/frontends/amiga/schedule.c
@@ -90,6 +90,10 @@ static nserror ami_schedule_add_timer_event(struct
nscallback *nscb, int t)
nscb->tv.Seconds = time_us / 1000000;
nscb->tv.Microseconds = time_us % 1000000;
+ if(nscb->tv.Microseconds >= 1000000) {
+ LOG("Microseconds invalid value: %ld", nscb->tv.Microseconds);
+ }
+
GetSysTime(&tv);
AddTime(&nscb->tv,&tv); // now contains time when event occurs
@@ -350,10 +354,6 @@ void ami_schedule_handle(struct MsgPort *nsmsgport)
struct TimerRequest *timermsg;
while((timermsg = (struct TimerRequest *)GetMsg(nsmsgport))) {
- /* reply first, as we don't need the message contents
and
- * it crashes if we reply after schedule_run has
executed.
- */
- ReplyMsg((struct Message *)timermsg);
ami_scheduler_run();
}
}
-----------------------------------------------------------------------
Summary of changes:
frontends/amiga/schedule.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/frontends/amiga/schedule.c b/frontends/amiga/schedule.c
index 6b8ee8b..f6145a1 100755
--- a/frontends/amiga/schedule.c
+++ b/frontends/amiga/schedule.c
@@ -90,6 +90,10 @@ static nserror ami_schedule_add_timer_event(struct
nscallback *nscb, int t)
nscb->tv.Seconds = time_us / 1000000;
nscb->tv.Microseconds = time_us % 1000000;
+ if(nscb->tv.Microseconds >= 1000000) {
+ LOG("Microseconds invalid value: %ld", nscb->tv.Microseconds);
+ }
+
GetSysTime(&tv);
AddTime(&nscb->tv,&tv); // now contains time when event occurs
@@ -350,10 +354,6 @@ void ami_schedule_handle(struct MsgPort *nsmsgport)
struct TimerRequest *timermsg;
while((timermsg = (struct TimerRequest *)GetMsg(nsmsgport))) {
- /* reply first, as we don't need the message contents
and
- * it crashes if we reply after schedule_run has
executed.
- */
- ReplyMsg((struct Message *)timermsg);
ami_scheduler_run();
}
}
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
