Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/2467a0a99080c0d707fcf443a2d91deed1a76c1d
...commit
http://git.netsurf-browser.org/netsurf.git/commit/2467a0a99080c0d707fcf443a2d91deed1a76c1d
...tree
http://git.netsurf-browser.org/netsurf.git/tree/2467a0a99080c0d707fcf443a2d91deed1a76c1d
The branch, master has been updated
via 2467a0a99080c0d707fcf443a2d91deed1a76c1d (commit)
from 703427a48612bf98fba599dfcd6e91485efd5b77 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=2467a0a99080c0d707fcf443a2d91deed1a76c1d
commit 2467a0a99080c0d707fcf443a2d91deed1a76c1d
Author: Vincent Sanders <[email protected]>
Commit: Vincent Sanders <[email protected]>
fix coverity issue 1372473 Out-of-bounds write
diff --git a/content/urldb.c b/content/urldb.c
index f553368..313ec31 100644
--- a/content/urldb.c
+++ b/content/urldb.c
@@ -696,8 +696,8 @@ static bool urldb__host_is_ip_address(const char *host)
}
ipv6_addr_len = host_len - 2;
- if (ipv6_addr_len > sizeof(ipv6_addr)) {
- ipv6_addr_len = sizeof(ipv6_addr);
+ if (ipv6_addr_len >= sizeof(ipv6_addr)) {
+ ipv6_addr_len = sizeof(ipv6_addr) - 1;
}
strncpy(ipv6_addr, sane_host + 1, ipv6_addr_len);
ipv6_addr[ipv6_addr_len] = '\0';
-----------------------------------------------------------------------
Summary of changes:
content/urldb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/content/urldb.c b/content/urldb.c
index f553368..313ec31 100644
--- a/content/urldb.c
+++ b/content/urldb.c
@@ -696,8 +696,8 @@ static bool urldb__host_is_ip_address(const char *host)
}
ipv6_addr_len = host_len - 2;
- if (ipv6_addr_len > sizeof(ipv6_addr)) {
- ipv6_addr_len = sizeof(ipv6_addr);
+ if (ipv6_addr_len >= sizeof(ipv6_addr)) {
+ ipv6_addr_len = sizeof(ipv6_addr) - 1;
}
strncpy(ipv6_addr, sane_host + 1, ipv6_addr_len);
ipv6_addr[ipv6_addr_len] = '\0';
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
