Gitweb links:

...log 
http://git.netsurf-browser.org/netsurf.git/shortlog/df79047cb62c26755f35083557686828849008b3
...commit 
http://git.netsurf-browser.org/netsurf.git/commit/df79047cb62c26755f35083557686828849008b3
...tree 
http://git.netsurf-browser.org/netsurf.git/tree/df79047cb62c26755f35083557686828849008b3

The branch, master has been updated
       via  df79047cb62c26755f35083557686828849008b3 (commit)
      from  e275b3175b710d3289e83bf0130bd0504951adc2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commitdiff 
http://git.netsurf-browser.org/netsurf.git/commit/?id=df79047cb62c26755f35083557686828849008b3
commit df79047cb62c26755f35083557686828849008b3
Author: Michael Drake <[email protected]>
Commit: Michael Drake <[email protected]>

    GTK: Squash a couple of warnings from GCC 8.2.
    
    frontends/gtk/download.c: In function ‘nsgtk_download_do’:
    frontends/gtk/download.c:238:24: warning: cast between incompatible function
    types from ‘void (*)(GtkTreePath *)’ {aka ‘void (*)(struct _GtkTreePath *)’}
    to ‘void (*)(void *, void *)’ [-Wcast-function-type]
       g_list_foreach(rows, (GFunc)gtk_tree_path_free, NULL);
                            ^
    frontends/gtk/download.c:239:24: warning: cast between incompatible function
    types from ‘void (*)(void *)’ to ‘void (*)(void *, void *)’ 
[-Wcast-function-type]
       g_list_foreach(rows, (GFunc)g_free, NULL);
                            ^

diff --git a/frontends/gtk/download.c b/frontends/gtk/download.c
index d11036e..57f92bf 100644
--- a/frontends/gtk/download.c
+++ b/frontends/gtk/download.c
@@ -212,6 +212,26 @@ static void 
nsgtk_download_sensitivity_evaluate(GtkTreeSelection *selection)
        nsgtk_download_sensitivity_update_buttons(sensitivity);
 }
 
+/**
+ * Wrapper to GFunc-ify gtk_tree_path_free for g_list_foreach.
+ */
+static void nsgtk_download_gfunc__gtk_tree_path_free(
+               gpointer data,
+               gpointer user_data)
+{
+       gtk_tree_path_free(data);
+}
+
+/**
+ * Wrapper to GFunc-ify g_free for g_list_foreach.
+ */
+static void nsgtk_download_gfunc__g_free(
+               gpointer data,
+               gpointer user_data)
+{
+       g_free(data);
+}
+
 static void nsgtk_download_do(nsgtk_download_selection_action action)
 {
        GList *rows, *dls = NULL;
@@ -235,8 +255,8 @@ static void 
nsgtk_download_do(nsgtk_download_selection_action action)
 
                        rows = rows->next;
                }
-               g_list_foreach(rows, (GFunc)gtk_tree_path_free, NULL);
-               g_list_foreach(rows, (GFunc)g_free, NULL);
+               g_list_foreach(rows, nsgtk_download_gfunc__gtk_tree_path_free, 
NULL);
+               g_list_foreach(rows, nsgtk_download_gfunc__g_free, NULL);
                g_list_free(rows);
        } else
                dls = g_list_copy(nsgtk_downloads_list);


-----------------------------------------------------------------------

Summary of changes:
 frontends/gtk/download.c |   24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/frontends/gtk/download.c b/frontends/gtk/download.c
index d11036e..57f92bf 100644
--- a/frontends/gtk/download.c
+++ b/frontends/gtk/download.c
@@ -212,6 +212,26 @@ static void 
nsgtk_download_sensitivity_evaluate(GtkTreeSelection *selection)
        nsgtk_download_sensitivity_update_buttons(sensitivity);
 }
 
+/**
+ * Wrapper to GFunc-ify gtk_tree_path_free for g_list_foreach.
+ */
+static void nsgtk_download_gfunc__gtk_tree_path_free(
+               gpointer data,
+               gpointer user_data)
+{
+       gtk_tree_path_free(data);
+}
+
+/**
+ * Wrapper to GFunc-ify g_free for g_list_foreach.
+ */
+static void nsgtk_download_gfunc__g_free(
+               gpointer data,
+               gpointer user_data)
+{
+       g_free(data);
+}
+
 static void nsgtk_download_do(nsgtk_download_selection_action action)
 {
        GList *rows, *dls = NULL;
@@ -235,8 +255,8 @@ static void 
nsgtk_download_do(nsgtk_download_selection_action action)
 
                        rows = rows->next;
                }
-               g_list_foreach(rows, (GFunc)gtk_tree_path_free, NULL);
-               g_list_foreach(rows, (GFunc)g_free, NULL);
+               g_list_foreach(rows, nsgtk_download_gfunc__gtk_tree_path_free, 
NULL);
+               g_list_foreach(rows, nsgtk_download_gfunc__g_free, NULL);
                g_list_free(rows);
        } else
                dls = g_list_copy(nsgtk_downloads_list);


-- 
NetSurf Browser

_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org

Reply via email to