Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/e4f57437f6ef0f0fc25f8ca2846ea606cb22c017
...commit
http://git.netsurf-browser.org/netsurf.git/commit/e4f57437f6ef0f0fc25f8ca2846ea606cb22c017
...tree
http://git.netsurf-browser.org/netsurf.git/tree/e4f57437f6ef0f0fc25f8ca2846ea606cb22c017
The branch, master has been updated
via e4f57437f6ef0f0fc25f8ca2846ea606cb22c017 (commit)
via 99809ee64669da845f28808361ebd7e7dea5fd6c (commit)
from a03b4a3c14768b262547ebc64b12b12f09910eef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=e4f57437f6ef0f0fc25f8ca2846ea606cb22c017
commit e4f57437f6ef0f0fc25f8ca2846ea606cb22c017
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Unref body when finished getting event handler
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/dukky.c
b/content/handlers/javascript/duktape/dukky.c
index a2bcad0..6d130e2 100644
--- a/content/handlers/javascript/duktape/dukky.c
+++ b/content/handlers/javascript/duktape/dukky.c
@@ -1343,10 +1343,14 @@ bool js_fire_event(jscontext *ctx, const char *type,
struct dom_document *doc, s
/* ... handlers bodynode */
if (dukky_get_current_value_of_event_handler(
CTX, corestring_dom_load, body) == false) {
+ /* Unref the body, we don't need it any more */
+ dom_node_unref(body);
/* ... handlers */
duk_pop(CTX);
return true;
}
+ /* Unref the body, we don't need it any more */
+ dom_node_unref(body);
/* ... handlers handler bodynode */
duk_pop(CTX);
}
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=99809ee64669da845f28808361ebd7e7dea5fd6c
commit 99809ee64669da845f28808361ebd7e7dea5fd6c
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Better dukky debug for node creation
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/dukky.c
b/content/handlers/javascript/duktape/dukky.c
index 5b3c12b..a2bcad0 100644
--- a/content/handlers/javascript/duktape/dukky.c
+++ b/content/handlers/javascript/duktape/dukky.c
@@ -163,6 +163,12 @@ dukky_push_node_stacked(duk_context *ctx)
/* ... node nodeptr klass nodes */
duk_pop_3(ctx);
/* ... node */
+ {
+ duk_dup(ctx, -1);
+ const char * what = duk_safe_to_string(ctx, -1);
+ NSLOG(dukky, DEEPDEBUG, "Created: %s", what);
+ duk_pop(ctx);
+ }
return true;
}
@@ -457,7 +463,12 @@ dukky_push_node(duk_context *ctx, struct dom_node *node)
/* ... node nodes */
duk_pop(ctx);
/* ... node */
- NSLOG(dukky, DEEPDEBUG, "Found it memoised");
+ {
+ duk_dup(ctx, -1);
+ const char * what = duk_safe_to_string(ctx, -1);
+ NSLOG(dukky, DEEPDEBUG, "Found it memoised: %s", what);
+ duk_pop(ctx);
+ }
return true;
}
/* ... nodes undefined */
-----------------------------------------------------------------------
Summary of changes:
content/handlers/javascript/duktape/dukky.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/content/handlers/javascript/duktape/dukky.c
b/content/handlers/javascript/duktape/dukky.c
index 5b3c12b..6d130e2 100644
--- a/content/handlers/javascript/duktape/dukky.c
+++ b/content/handlers/javascript/duktape/dukky.c
@@ -163,6 +163,12 @@ dukky_push_node_stacked(duk_context *ctx)
/* ... node nodeptr klass nodes */
duk_pop_3(ctx);
/* ... node */
+ {
+ duk_dup(ctx, -1);
+ const char * what = duk_safe_to_string(ctx, -1);
+ NSLOG(dukky, DEEPDEBUG, "Created: %s", what);
+ duk_pop(ctx);
+ }
return true;
}
@@ -457,7 +463,12 @@ dukky_push_node(duk_context *ctx, struct dom_node *node)
/* ... node nodes */
duk_pop(ctx);
/* ... node */
- NSLOG(dukky, DEEPDEBUG, "Found it memoised");
+ {
+ duk_dup(ctx, -1);
+ const char * what = duk_safe_to_string(ctx, -1);
+ NSLOG(dukky, DEEPDEBUG, "Found it memoised: %s", what);
+ duk_pop(ctx);
+ }
return true;
}
/* ... nodes undefined */
@@ -1332,10 +1343,14 @@ bool js_fire_event(jscontext *ctx, const char *type,
struct dom_document *doc, s
/* ... handlers bodynode */
if (dukky_get_current_value_of_event_handler(
CTX, corestring_dom_load, body) == false) {
+ /* Unref the body, we don't need it any more */
+ dom_node_unref(body);
/* ... handlers */
duk_pop(CTX);
return true;
}
+ /* Unref the body, we don't need it any more */
+ dom_node_unref(body);
/* ... handlers handler bodynode */
duk_pop(CTX);
}
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
