Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/e82107a29611f9d77a8699bac625df4524563137
...commit
http://git.netsurf-browser.org/netsurf.git/commit/e82107a29611f9d77a8699bac625df4524563137
...tree
http://git.netsurf-browser.org/netsurf.git/tree/e82107a29611f9d77a8699bac625df4524563137
The branch, master has been updated
via e82107a29611f9d77a8699bac625df4524563137 (commit)
via 03624bcf7a0128979be1a9c60852cb230b9dc0db (commit)
via c5c8a492764d9e31a6d4cf87ae0fd16245ea7805 (commit)
from 04cf2fe588987e58bb17e83b2a2c39f73a6bd23c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=e82107a29611f9d77a8699bac625df4524563137
commit e82107a29611f9d77a8699bac625df4524563137
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Window.bnd: Suppress some unnecessary stack frame dumps
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/Window.bnd
b/content/handlers/javascript/duktape/Window.bnd
index db588c0..39c58c4 100644
--- a/content/handlers/javascript/duktape/Window.bnd
+++ b/content/handlers/javascript/duktape/Window.bnd
@@ -63,7 +63,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
/* ..., win, cbt, handle */
duk_get_prop(ctx, -2);
/* ..., win, cbt, cbo */
- dukky_log_stack_frame(ctx, "On entry to callback");
+ //dukky_log_stack_frame(ctx, "On entry to callback");
/* ..., win, cbt, cbo */
/* What we want to do is call cbo.func passing all of cbo.args */
duk_get_prop_string(ctx, -1, "func");
@@ -77,7 +77,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
/* ..., win, cbt, cbo, func, argarr, args... */
duk_remove(ctx, -(arrlen+1));
/* ..., win, cbt, cbo, func, args... */
- dukky_log_stack_frame(ctx, "Just before call");
+ //dukky_log_stack_frame(ctx, "Just before call");
(void) dukky_pcall(ctx, arrlen, true);
/* ..., win, cbt, cbo, retval */
if (clear_entry) {
@@ -93,7 +93,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
duk_pop_n(ctx, 4);
}
/* ... */
- dukky_log_stack_frame(ctx, "On leaving callback");
+ //dukky_log_stack_frame(ctx, "On leaving callback");
}
static void window_schedule_callback(void *p) {
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=03624bcf7a0128979be1a9c60852cb230b9dc0db
commit 03624bcf7a0128979be1a9c60852cb230b9dc0db
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
browser.c: Don't require > 0 chars in logging
Sometimes JavaScript chooses to log an empty string. We should
honour that by requiring msg be a valid empty string.
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/desktop/browser.c b/desktop/browser.c
index f18768b..a3664ac 100644
--- a/desktop/browser.c
+++ b/desktop/browser.c
@@ -3458,7 +3458,10 @@ nserror browser_window_console_log(struct browser_window
*bw,
struct browser_window *root = browser_window_get_root(bw);
assert(msg != NULL);
- assert(msglen > 0);
+ /* We don't assert msglen > 0, if someone wants to log a real empty
+ * string then we won't stop them. It does sometimes happen from
+ * JavaScript for example.
+ */
/* bw is the target of the log, but root is where we log it */
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=c5c8a492764d9e31a6d4cf87ae0fd16245ea7805
commit c5c8a492764d9e31a6d4cf87ae0fd16245ea7805
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Window.bnd: Expose isNan
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/Window.bnd
b/content/handlers/javascript/duktape/Window.bnd
index 731b2a3..db588c0 100644
--- a/content/handlers/javascript/duktape/Window.bnd
+++ b/content/handlers/javascript/duktape/Window.bnd
@@ -264,6 +264,7 @@ prototype Window()
EXPOSE(encodeURI);
EXPOSE(encodeURIComponent);
EXPOSE(NaN);
+ EXPOSE(isNaN);
#undef EXPOSE
/* Add s3kr1t method to close the compartment */
duk_dup(ctx, 0);
-----------------------------------------------------------------------
Summary of changes:
content/handlers/javascript/duktape/Window.bnd | 7 ++++---
desktop/browser.c | 5 ++++-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/content/handlers/javascript/duktape/Window.bnd
b/content/handlers/javascript/duktape/Window.bnd
index 731b2a3..39c58c4 100644
--- a/content/handlers/javascript/duktape/Window.bnd
+++ b/content/handlers/javascript/duktape/Window.bnd
@@ -63,7 +63,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
/* ..., win, cbt, handle */
duk_get_prop(ctx, -2);
/* ..., win, cbt, cbo */
- dukky_log_stack_frame(ctx, "On entry to callback");
+ //dukky_log_stack_frame(ctx, "On entry to callback");
/* ..., win, cbt, cbo */
/* What we want to do is call cbo.func passing all of cbo.args */
duk_get_prop_string(ctx, -1, "func");
@@ -77,7 +77,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
/* ..., win, cbt, cbo, func, argarr, args... */
duk_remove(ctx, -(arrlen+1));
/* ..., win, cbt, cbo, func, args... */
- dukky_log_stack_frame(ctx, "Just before call");
+ //dukky_log_stack_frame(ctx, "Just before call");
(void) dukky_pcall(ctx, arrlen, true);
/* ..., win, cbt, cbo, retval */
if (clear_entry) {
@@ -93,7 +93,7 @@ static void window_call_callback(duk_context *ctx, size_t
handle, bool clear_ent
duk_pop_n(ctx, 4);
}
/* ... */
- dukky_log_stack_frame(ctx, "On leaving callback");
+ //dukky_log_stack_frame(ctx, "On leaving callback");
}
static void window_schedule_callback(void *p) {
@@ -264,6 +264,7 @@ prototype Window()
EXPOSE(encodeURI);
EXPOSE(encodeURIComponent);
EXPOSE(NaN);
+ EXPOSE(isNaN);
#undef EXPOSE
/* Add s3kr1t method to close the compartment */
duk_dup(ctx, 0);
diff --git a/desktop/browser.c b/desktop/browser.c
index f18768b..a3664ac 100644
--- a/desktop/browser.c
+++ b/desktop/browser.c
@@ -3458,7 +3458,10 @@ nserror browser_window_console_log(struct browser_window
*bw,
struct browser_window *root = browser_window_get_root(bw);
assert(msg != NULL);
- assert(msglen > 0);
+ /* We don't assert msglen > 0, if someone wants to log a real empty
+ * string then we won't stop them. It does sometimes happen from
+ * JavaScript for example.
+ */
/* bw is the target of the log, but root is where we log it */
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
