Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/8b6f590aaa8d110ef6f62befb792827c16d7e75a
...commit
http://git.netsurf-browser.org/netsurf.git/commit/8b6f590aaa8d110ef6f62befb792827c16d7e75a
...tree
http://git.netsurf-browser.org/netsurf.git/tree/8b6f590aaa8d110ef6f62befb792827c16d7e75a
The branch, master has been updated
via 8b6f590aaa8d110ef6f62befb792827c16d7e75a (commit)
from 1951c0f8094ab74abd1873e622a8a79f2627c7fc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=8b6f590aaa8d110ef6f62befb792827c16d7e75a
commit 8b6f590aaa8d110ef6f62befb792827c16d7e75a
Author: Vincent Sanders <[email protected]>
Commit: Vincent Sanders <[email protected]>
prevent out of bounds access when checking IDNA host label
diff --git a/utils/idna.c b/utils/idna.c
index 70d321d..d657f90 100644
--- a/utils/idna.c
+++ b/utils/idna.c
@@ -437,7 +437,7 @@ static bool idna__is_valid(int32_t *label, size_t len)
*/
/* 2. Check characters 3 and 4 are not '--'. */
- if ((label[2] == 0x002d) && (label[3] == 0x002d)) {
+ if ((len >= 4) && (label[2] == 0x002d) && (label[3] == 0x002d)) {
NSLOG(netsurf, INFO,
"Check failed: characters 2 and 3 are '--'");
return false;
-----------------------------------------------------------------------
Summary of changes:
utils/idna.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/idna.c b/utils/idna.c
index 70d321d..d657f90 100644
--- a/utils/idna.c
+++ b/utils/idna.c
@@ -437,7 +437,7 @@ static bool idna__is_valid(int32_t *label, size_t len)
*/
/* 2. Check characters 3 and 4 are not '--'. */
- if ((label[2] == 0x002d) && (label[3] == 0x002d)) {
+ if ((len >= 4) && (label[2] == 0x002d) && (label[3] == 0x002d)) {
NSLOG(netsurf, INFO,
"Check failed: characters 2 and 3 are '--'");
return false;
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
