Gitweb links:

...log 
http://git.netsurf-browser.org/libdom.git/shortlog/9ed8fb0d80aeb7ba856085018d3bd367e9a625de
...commit 
http://git.netsurf-browser.org/libdom.git/commit/9ed8fb0d80aeb7ba856085018d3bd367e9a625de
...tree 
http://git.netsurf-browser.org/libdom.git/tree/9ed8fb0d80aeb7ba856085018d3bd367e9a625de

The branch, master has been updated
       via  9ed8fb0d80aeb7ba856085018d3bd367e9a625de (commit)
      from  2f067d910b4fbdf3f983381b47232f2eb71754d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commitdiff 
http://git.netsurf-browser.org/libdom.git/commit/?id=9ed8fb0d80aeb7ba856085018d3bd367e9a625de
commit 9ed8fb0d80aeb7ba856085018d3bd367e9a625de
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>

    element: Issue DOMSubtreeModified *after* updating attr value
    
    Signed-off-by: Daniel Silverstone <[email protected]>

diff --git a/src/core/element.c b/src/core/element.c
index 1dae60a..771226b 100644
--- a/src/core/element.c
+++ b/src/core/element.c
@@ -1661,13 +1661,13 @@ dom_exception _dom_element_set_attr(struct dom_element 
*element,
                if (err != DOM_NO_ERR)
                        return err;
 
-               success = true;
-               err = _dom_dispatch_subtree_modified_event(doc,
-                               (dom_event_target *) e, &success);
+               err = dom_attr_set_value(match->attr, value);
                if (err != DOM_NO_ERR)
                        return err;
 
-               err = dom_attr_set_value(match->attr, value);
+               success = true;
+               err = _dom_dispatch_subtree_modified_event(doc,
+                               (dom_event_target *) e, &success);
                if (err != DOM_NO_ERR)
                        return err;
        } else {


-----------------------------------------------------------------------

Summary of changes:
 src/core/element.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/core/element.c b/src/core/element.c
index 1dae60a..771226b 100644
--- a/src/core/element.c
+++ b/src/core/element.c
@@ -1661,13 +1661,13 @@ dom_exception _dom_element_set_attr(struct dom_element 
*element,
                if (err != DOM_NO_ERR)
                        return err;
 
-               success = true;
-               err = _dom_dispatch_subtree_modified_event(doc,
-                               (dom_event_target *) e, &success);
+               err = dom_attr_set_value(match->attr, value);
                if (err != DOM_NO_ERR)
                        return err;
 
-               err = dom_attr_set_value(match->attr, value);
+               success = true;
+               err = _dom_dispatch_subtree_modified_event(doc,
+                               (dom_event_target *) e, &success);
                if (err != DOM_NO_ERR)
                        return err;
        } else {


-- 
Document Object Model library

_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org

Reply via email to