Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/9a02a41cd61d7fa4a58d234e7240ff41205a7e54
...commit
http://git.netsurf-browser.org/netsurf.git/commit/9a02a41cd61d7fa4a58d234e7240ff41205a7e54
...tree
http://git.netsurf-browser.org/netsurf.git/tree/9a02a41cd61d7fa4a58d234e7240ff41205a7e54
The branch, master has been updated
via 9a02a41cd61d7fa4a58d234e7240ff41205a7e54 (commit)
from 14c7b4aee30462db6488c6084a64ce40aaaef6a1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=9a02a41cd61d7fa4a58d234e7240ff41205a7e54
commit 9a02a41cd61d7fa4a58d234e7240ff41205a7e54
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
box_construct: Do not leak attributes in <embed> boxes
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/html/box_construct.c
b/content/handlers/html/box_construct.c
index f0d68ac..50d1027 100644
--- a/content/handlers/html/box_construct.c
+++ b/content/handlers/html/box_construct.c
@@ -2998,17 +2998,20 @@ bool box_embed(BOX_SPECIAL_PARAMS)
err = dom_attr_get_name(attr, &name);
if (err != DOM_NO_ERR) {
+ dom_node_unref(attr);
dom_namednodemap_unref(attrs);
return false;
}
if (dom_string_caseless_lwc_isequal(name, corestring_lwc_src)) {
+ dom_node_unref(attr);
dom_string_unref(name);
continue;
}
err = dom_attr_get_value(attr, &value);
if (err != DOM_NO_ERR) {
+ dom_node_unref(attr);
dom_string_unref(name);
dom_namednodemap_unref(attrs);
return false;
@@ -3016,6 +3019,7 @@ bool box_embed(BOX_SPECIAL_PARAMS)
param = talloc(content->bctx, struct object_param);
if (param == NULL) {
+ dom_node_unref(attr);
dom_string_unref(value);
dom_string_unref(name);
dom_namednodemap_unref(attrs);
@@ -3030,6 +3034,7 @@ bool box_embed(BOX_SPECIAL_PARAMS)
dom_string_unref(value);
dom_string_unref(name);
+ dom_node_unref(attr);
if (param->name == NULL || param->value == NULL ||
param->valuetype == NULL) {
-----------------------------------------------------------------------
Summary of changes:
content/handlers/html/box_construct.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/content/handlers/html/box_construct.c
b/content/handlers/html/box_construct.c
index f0d68ac..50d1027 100644
--- a/content/handlers/html/box_construct.c
+++ b/content/handlers/html/box_construct.c
@@ -2998,17 +2998,20 @@ bool box_embed(BOX_SPECIAL_PARAMS)
err = dom_attr_get_name(attr, &name);
if (err != DOM_NO_ERR) {
+ dom_node_unref(attr);
dom_namednodemap_unref(attrs);
return false;
}
if (dom_string_caseless_lwc_isequal(name, corestring_lwc_src)) {
+ dom_node_unref(attr);
dom_string_unref(name);
continue;
}
err = dom_attr_get_value(attr, &value);
if (err != DOM_NO_ERR) {
+ dom_node_unref(attr);
dom_string_unref(name);
dom_namednodemap_unref(attrs);
return false;
@@ -3016,6 +3019,7 @@ bool box_embed(BOX_SPECIAL_PARAMS)
param = talloc(content->bctx, struct object_param);
if (param == NULL) {
+ dom_node_unref(attr);
dom_string_unref(value);
dom_string_unref(name);
dom_namednodemap_unref(attrs);
@@ -3030,6 +3034,7 @@ bool box_embed(BOX_SPECIAL_PARAMS)
dom_string_unref(value);
dom_string_unref(name);
+ dom_node_unref(attr);
if (param->name == NULL || param->value == NULL ||
param->valuetype == NULL) {
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
