Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/92caa16cfcd10ecc2024972fbef740fbdbd3254b
...commit
http://git.netsurf-browser.org/netsurf.git/commit/92caa16cfcd10ecc2024972fbef740fbdbd3254b
...tree
http://git.netsurf-browser.org/netsurf.git/tree/92caa16cfcd10ecc2024972fbef740fbdbd3254b
The branch, master has been updated
via 92caa16cfcd10ecc2024972fbef740fbdbd3254b (commit)
from 5063fc838e9933b73bf6c8d2f330e5a8e53d7544 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=92caa16cfcd10ecc2024972fbef740fbdbd3254b
commit 92caa16cfcd10ecc2024972fbef740fbdbd3254b
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Add missing unrefs
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/content.c b/content/content.c
index a87be00..552ee07 100644
--- a/content/content.c
+++ b/content/content.c
@@ -592,6 +592,7 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok &&
(match == true))) {
/* No insecurity to find */
+ lwc_string_unref(scheme);
return false;
}
@@ -600,9 +601,11 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok)
&& (match == false)) {
/* I did see something insecure -- ME! */
+ lwc_string_unref(scheme);
return true;
}
+ lwc_string_unref(scheme);
/* I am supposed to be secure, but was I overridden */
if (urldb_get_cert_permissions(url)) {
/* I was https:// but I was overridden, that's no good */
diff --git a/desktop/browser_window.c b/desktop/browser_window.c
index 1fa3161..16fa73e 100644
--- a/desktop/browser_window.c
+++ b/desktop/browser_window.c
@@ -4671,6 +4671,7 @@ browser_window_page_info_state
browser_window_get_page_info_state(
(lwc_string_isequal(scheme, corestring_lwc_resource,
&match) == lwc_error_ok &&
(match == true))) {
+ lwc_string_unref(scheme);
return PAGE_STATE_INTERNAL;
}
@@ -4678,6 +4679,7 @@ browser_window_page_info_state
browser_window_get_page_info_state(
if (lwc_string_isequal(scheme, corestring_lwc_file,
&match) == lwc_error_ok &&
match == true) {
+ lwc_string_unref(scheme);
return PAGE_STATE_LOCAL;
}
@@ -4686,9 +4688,12 @@ browser_window_page_info_state
browser_window_get_page_info_state(
&match) == lwc_error_ok &&
(match == false))) {
/* Some remote content, not https, therefore insecure */
+ lwc_string_unref(scheme);
return PAGE_STATE_INSECURE;
}
+ lwc_string_unref(scheme);
+
/* Did we have to override this SSL setting? */
if (urldb_get_cert_permissions(bw->current_parameters.url)) {
return PAGE_STATE_SECURE_OVERRIDE;
-----------------------------------------------------------------------
Summary of changes:
content/content.c | 3 +++
desktop/browser_window.c | 5 +++++
2 files changed, 8 insertions(+)
diff --git a/content/content.c b/content/content.c
index a87be00..552ee07 100644
--- a/content/content.c
+++ b/content/content.c
@@ -592,6 +592,7 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok &&
(match == true))) {
/* No insecurity to find */
+ lwc_string_unref(scheme);
return false;
}
@@ -600,9 +601,11 @@ bool content_saw_insecure_objects(struct hlcache_handle *h)
&match) == lwc_error_ok)
&& (match == false)) {
/* I did see something insecure -- ME! */
+ lwc_string_unref(scheme);
return true;
}
+ lwc_string_unref(scheme);
/* I am supposed to be secure, but was I overridden */
if (urldb_get_cert_permissions(url)) {
/* I was https:// but I was overridden, that's no good */
diff --git a/desktop/browser_window.c b/desktop/browser_window.c
index 1fa3161..16fa73e 100644
--- a/desktop/browser_window.c
+++ b/desktop/browser_window.c
@@ -4671,6 +4671,7 @@ browser_window_page_info_state
browser_window_get_page_info_state(
(lwc_string_isequal(scheme, corestring_lwc_resource,
&match) == lwc_error_ok &&
(match == true))) {
+ lwc_string_unref(scheme);
return PAGE_STATE_INTERNAL;
}
@@ -4678,6 +4679,7 @@ browser_window_page_info_state
browser_window_get_page_info_state(
if (lwc_string_isequal(scheme, corestring_lwc_file,
&match) == lwc_error_ok &&
match == true) {
+ lwc_string_unref(scheme);
return PAGE_STATE_LOCAL;
}
@@ -4686,9 +4688,12 @@ browser_window_page_info_state
browser_window_get_page_info_state(
&match) == lwc_error_ok &&
(match == false))) {
/* Some remote content, not https, therefore insecure */
+ lwc_string_unref(scheme);
return PAGE_STATE_INSECURE;
}
+ lwc_string_unref(scheme);
+
/* Did we have to override this SSL setting? */
if (urldb_get_cert_permissions(bw->current_parameters.url)) {
return PAGE_STATE_SECURE_OVERRIDE;
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
