Gitweb links:
...log
http://git.netsurf-browser.org/libhubbub.git/shortlog/d7e13fb32073aac9aba97fa6021da064302fcd72
...commit
http://git.netsurf-browser.org/libhubbub.git/commit/d7e13fb32073aac9aba97fa6021da064302fcd72
...tree
http://git.netsurf-browser.org/libhubbub.git/tree/d7e13fb32073aac9aba97fa6021da064302fcd72
The branch, master has been updated
via d7e13fb32073aac9aba97fa6021da064302fcd72 (commit)
from 050c36d483378d52cd8330fd0dcf3dfd4119ec78 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/libhubbub.git/commit/?id=d7e13fb32073aac9aba97fa6021da064302fcd72
commit d7e13fb32073aac9aba97fa6021da064302fcd72
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
treebuilder: Add some asserts to hopefully quieten scan-build
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/src/treebuilder/treebuilder.c b/src/treebuilder/treebuilder.c
index b67aa53..19f4429 100644
--- a/src/treebuilder/treebuilder.c
+++ b/src/treebuilder/treebuilder.c
@@ -1391,15 +1391,21 @@ hubbub_error formatting_list_remove(hubbub_treebuilder
*treebuilder,
*node = entry->details.node;
*stack_index = entry->stack_index;
- if (entry->prev == NULL)
+ if (entry->prev == NULL) {
+ assert(treebuilder->context.formatting_list == entry);
treebuilder->context.formatting_list = entry->next;
- else
+ } else {
+ assert(treebuilder->context.formatting_list != entry);
entry->prev->next = entry->next;
+ }
- if (entry->next == NULL)
+ if (entry->next == NULL) {
+ assert(treebuilder->context.formatting_list_end == entry);
treebuilder->context.formatting_list_end = entry->prev;
- else
+ } else {
+ assert(treebuilder->context.formatting_list_end != entry);
entry->next->prev = entry->prev;
+ }
free(entry);
-----------------------------------------------------------------------
Summary of changes:
src/treebuilder/treebuilder.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/treebuilder/treebuilder.c b/src/treebuilder/treebuilder.c
index b67aa53..19f4429 100644
--- a/src/treebuilder/treebuilder.c
+++ b/src/treebuilder/treebuilder.c
@@ -1391,15 +1391,21 @@ hubbub_error formatting_list_remove(hubbub_treebuilder
*treebuilder,
*node = entry->details.node;
*stack_index = entry->stack_index;
- if (entry->prev == NULL)
+ if (entry->prev == NULL) {
+ assert(treebuilder->context.formatting_list == entry);
treebuilder->context.formatting_list = entry->next;
- else
+ } else {
+ assert(treebuilder->context.formatting_list != entry);
entry->prev->next = entry->next;
+ }
- if (entry->next == NULL)
+ if (entry->next == NULL) {
+ assert(treebuilder->context.formatting_list_end == entry);
treebuilder->context.formatting_list_end = entry->prev;
- else
+ } else {
+ assert(treebuilder->context.formatting_list_end != entry);
entry->next->prev = entry->prev;
+ }
free(entry);
--
HTML5 parser library
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
