Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/bc94555d9e5f51bc044a1a3413a932d69190f503
...commit
http://git.netsurf-browser.org/netsurf.git/commit/bc94555d9e5f51bc044a1a3413a932d69190f503
...tree
http://git.netsurf-browser.org/netsurf.git/tree/bc94555d9e5f51bc044a1a3413a932d69190f503
The branch, master has been updated
via bc94555d9e5f51bc044a1a3413a932d69190f503 (commit)
via 16163aab0318c2c1a1576cbc4d87c8ba0f36b766 (commit)
via b633bef7bf326ce22e89cf40a4dad5ecbcee9400 (commit)
via 1ecc36384d51449248e2469aa6ee24ef5576bbd6 (commit)
via bfd185ac49ee40eb9ef304e03581b1e328b15336 (commit)
from 614ca752f39c5a244b5b804161ece5518c422622 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=bc94555d9e5f51bc044a1a3413a932d69190f503
commit bc94555d9e5f51bc044a1a3413a932d69190f503
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
hotlist: Report if infallible destruction fails
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/desktop/hotlist.c b/desktop/hotlist.c
index 4daaaed..e9cbb5f 100644
--- a/desktop/hotlist.c
+++ b/desktop/hotlist.c
@@ -1403,6 +1403,9 @@ nserror hotlist_fini(void)
/* Destroy the hotlist treeview */
err = treeview_destroy(hl_ctx.tree);
+ if (err != NSERROR_OK) {
+ NSLOG(netsurf, INFO, "Problem destroying the hotlist
treeview.");
+ }
hl_ctx.built = false;
/* Free hotlist treeview entry fields */
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=16163aab0318c2c1a1576cbc4d87c8ba0f36b766
commit 16163aab0318c2c1a1576cbc4d87c8ba0f36b766
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
HTML: Ignore dom exceptions we don't care about
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/html/html.c b/content/handlers/html/html.c
index d9fe904..d1b810f 100644
--- a/content/handlers/html/html.c
+++ b/content/handlers/html/html.c
@@ -340,7 +340,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_hreflang, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the href lang */
- exc = dom_string_intern(atr_string, &link.hreflang);
+ (void)dom_string_intern(atr_string, &link.hreflang);
dom_string_unref(atr_string);
}
@@ -348,7 +348,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_type, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the type */
- exc = dom_string_intern(atr_string, &link.type);
+ (void)dom_string_intern(atr_string, &link.type);
dom_string_unref(atr_string);
}
@@ -356,7 +356,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_media, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the media */
- exc = dom_string_intern(atr_string, &link.media);
+ (void)dom_string_intern(atr_string, &link.media);
dom_string_unref(atr_string);
}
@@ -364,7 +364,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_sizes, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the sizes */
- exc = dom_string_intern(atr_string, &link.sizes);
+ (void)dom_string_intern(atr_string, &link.sizes);
dom_string_unref(atr_string);
}
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=b633bef7bf326ce22e89cf40a4dad5ecbcee9400
commit b633bef7bf326ce22e89cf40a4dad5ecbcee9400
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
Node: nodeValue setter should return value set into node
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/Node.bnd
b/content/handlers/javascript/duktape/Node.bnd
index 98fb5dd..8cd0794 100644
--- a/content/handlers/javascript/duktape/Node.bnd
+++ b/content/handlers/javascript/duktape/Node.bnd
@@ -221,7 +221,8 @@ setter Node::nodeValue()
if (exc != DOM_NO_ERR) return 0;
exc = dom_node_set_node_value(priv->node, content);
dom_string_unref(content);
- return 0;
+ if (exc != DOM_NO_ERR) return 0;
+ return 1;
%}
getter Node::textContent()
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=1ecc36384d51449248e2469aa6ee24ef5576bbd6
commit 1ecc36384d51449248e2469aa6ee24ef5576bbd6
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
browser_window: Propagate error code when handling errors
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/desktop/browser_window.c b/desktop/browser_window.c
index 838e62d..06f41dd 100644
--- a/desktop/browser_window.c
+++ b/desktop/browser_window.c
@@ -1315,7 +1315,7 @@ browser_window__handle_error(struct browser_window *bw,
break;
}
- return NSERROR_OK;
+ return res;
}
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=bfd185ac49ee40eb9ef304e03581b1e328b15336
commit bfd185ac49ee40eb9ef304e03581b1e328b15336
Author: Daniel Silverstone <[email protected]>
Commit: Daniel Silverstone <[email protected]>
dukky: Guard pointless work for deep debug
Signed-off-by: Daniel Silverstone <[email protected]>
diff --git a/content/handlers/javascript/duktape/dukky.c
b/content/handlers/javascript/duktape/dukky.c
index 4d21573..dcbff68 100644
--- a/content/handlers/javascript/duktape/dukky.c
+++ b/content/handlers/javascript/duktape/dukky.c
@@ -179,7 +179,7 @@ dukky_push_node_stacked(duk_context *ctx)
/* ... node nodeptr klass nodes */
duk_pop_3(ctx);
/* ... node */
- {
+ if (NSLOG_COMPILED_MIN_LEVEL <= NSLOG_LEVEL_DEEPDEBUG) {
duk_dup(ctx, -1);
const char * what = duk_safe_to_string(ctx, -1);
NSLOG(dukky, DEEPDEBUG, "Created: %s", what);
@@ -479,7 +479,7 @@ dukky_push_node(duk_context *ctx, struct dom_node *node)
/* ... node nodes */
duk_pop(ctx);
/* ... node */
- {
+ if (NSLOG_COMPILED_MIN_LEVEL <= NSLOG_LEVEL_DEEPDEBUG) {
duk_dup(ctx, -1);
const char * what = duk_safe_to_string(ctx, -1);
NSLOG(dukky, DEEPDEBUG, "Found it memoised: %s", what);
-----------------------------------------------------------------------
Summary of changes:
content/handlers/html/html.c | 8 ++++----
content/handlers/javascript/duktape/Node.bnd | 3 ++-
content/handlers/javascript/duktape/dukky.c | 4 ++--
desktop/browser_window.c | 2 +-
desktop/hotlist.c | 3 +++
5 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/content/handlers/html/html.c b/content/handlers/html/html.c
index d9fe904..d1b810f 100644
--- a/content/handlers/html/html.c
+++ b/content/handlers/html/html.c
@@ -340,7 +340,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_hreflang, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the href lang */
- exc = dom_string_intern(atr_string, &link.hreflang);
+ (void)dom_string_intern(atr_string, &link.hreflang);
dom_string_unref(atr_string);
}
@@ -348,7 +348,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_type, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the type */
- exc = dom_string_intern(atr_string, &link.type);
+ (void)dom_string_intern(atr_string, &link.type);
dom_string_unref(atr_string);
}
@@ -356,7 +356,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_media, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the media */
- exc = dom_string_intern(atr_string, &link.media);
+ (void)dom_string_intern(atr_string, &link.media);
dom_string_unref(atr_string);
}
@@ -364,7 +364,7 @@ static bool html_process_link(html_content *c, dom_node
*node)
corestring_dom_sizes, &atr_string);
if ((exc == DOM_NO_ERR) && (atr_string != NULL)) {
/* get a lwc string containing the sizes */
- exc = dom_string_intern(atr_string, &link.sizes);
+ (void)dom_string_intern(atr_string, &link.sizes);
dom_string_unref(atr_string);
}
diff --git a/content/handlers/javascript/duktape/Node.bnd
b/content/handlers/javascript/duktape/Node.bnd
index 98fb5dd..8cd0794 100644
--- a/content/handlers/javascript/duktape/Node.bnd
+++ b/content/handlers/javascript/duktape/Node.bnd
@@ -221,7 +221,8 @@ setter Node::nodeValue()
if (exc != DOM_NO_ERR) return 0;
exc = dom_node_set_node_value(priv->node, content);
dom_string_unref(content);
- return 0;
+ if (exc != DOM_NO_ERR) return 0;
+ return 1;
%}
getter Node::textContent()
diff --git a/content/handlers/javascript/duktape/dukky.c
b/content/handlers/javascript/duktape/dukky.c
index 4d21573..dcbff68 100644
--- a/content/handlers/javascript/duktape/dukky.c
+++ b/content/handlers/javascript/duktape/dukky.c
@@ -179,7 +179,7 @@ dukky_push_node_stacked(duk_context *ctx)
/* ... node nodeptr klass nodes */
duk_pop_3(ctx);
/* ... node */
- {
+ if (NSLOG_COMPILED_MIN_LEVEL <= NSLOG_LEVEL_DEEPDEBUG) {
duk_dup(ctx, -1);
const char * what = duk_safe_to_string(ctx, -1);
NSLOG(dukky, DEEPDEBUG, "Created: %s", what);
@@ -479,7 +479,7 @@ dukky_push_node(duk_context *ctx, struct dom_node *node)
/* ... node nodes */
duk_pop(ctx);
/* ... node */
- {
+ if (NSLOG_COMPILED_MIN_LEVEL <= NSLOG_LEVEL_DEEPDEBUG) {
duk_dup(ctx, -1);
const char * what = duk_safe_to_string(ctx, -1);
NSLOG(dukky, DEEPDEBUG, "Found it memoised: %s", what);
diff --git a/desktop/browser_window.c b/desktop/browser_window.c
index 838e62d..06f41dd 100644
--- a/desktop/browser_window.c
+++ b/desktop/browser_window.c
@@ -1315,7 +1315,7 @@ browser_window__handle_error(struct browser_window *bw,
break;
}
- return NSERROR_OK;
+ return res;
}
diff --git a/desktop/hotlist.c b/desktop/hotlist.c
index 4daaaed..e9cbb5f 100644
--- a/desktop/hotlist.c
+++ b/desktop/hotlist.c
@@ -1403,6 +1403,9 @@ nserror hotlist_fini(void)
/* Destroy the hotlist treeview */
err = treeview_destroy(hl_ctx.tree);
+ if (err != NSERROR_OK) {
+ NSLOG(netsurf, INFO, "Problem destroying the hotlist
treeview.");
+ }
hl_ctx.built = false;
/* Free hotlist treeview entry fields */
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
