Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/b8dc537bf82637d223332a6fa2ab95064acd63ee
...commit
http://git.netsurf-browser.org/netsurf.git/commit/b8dc537bf82637d223332a6fa2ab95064acd63ee
...tree
http://git.netsurf-browser.org/netsurf.git/tree/b8dc537bf82637d223332a6fa2ab95064acd63ee
The branch, master has been updated
via b8dc537bf82637d223332a6fa2ab95064acd63ee (commit)
from bb5d72410bf9a3a997ade1e8760b8f240d32af0d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=b8dc537bf82637d223332a6fa2ab95064acd63ee
commit b8dc537bf82637d223332a6fa2ab95064acd63ee
Author: Michael Drake <[email protected]>
Commit: Michael Drake <[email protected]>
Curl fetcher: Squash coverity warning.
CID 1419832: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "goto out;".
diff --git a/content/fetchers/curl.c b/content/fetchers/curl.c
index 39759cf..bd8c433 100644
--- a/content/fetchers/curl.c
+++ b/content/fetchers/curl.c
@@ -161,9 +161,8 @@ curl_fetch_ssl_key_eq(void *key1, void *key2)
if (port2 == NULL)
port2 = lwc_string_ref(corestring_lwc_443);
- if (lwc_string_isequal(hostname1, hostname2, &iseq) != lwc_error_ok)
- goto out;
- if (!iseq)
+ if (lwc_string_isequal(hostname1, hostname2, &iseq) != lwc_error_ok ||
+ iseq == false)
goto out;
iseq = false;
-----------------------------------------------------------------------
Summary of changes:
content/fetchers/curl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/content/fetchers/curl.c b/content/fetchers/curl.c
index 39759cf..bd8c433 100644
--- a/content/fetchers/curl.c
+++ b/content/fetchers/curl.c
@@ -161,9 +161,8 @@ curl_fetch_ssl_key_eq(void *key1, void *key2)
if (port2 == NULL)
port2 = lwc_string_ref(corestring_lwc_443);
- if (lwc_string_isequal(hostname1, hostname2, &iseq) != lwc_error_ok)
- goto out;
- if (!iseq)
+ if (lwc_string_isequal(hostname1, hostname2, &iseq) != lwc_error_ok ||
+ iseq == false)
goto out;
iseq = false;
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
