Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/f840833723e3f9be668b2ee633671c726f06bd3c
...commit
http://git.netsurf-browser.org/netsurf.git/commit/f840833723e3f9be668b2ee633671c726f06bd3c
...tree
http://git.netsurf-browser.org/netsurf.git/tree/f840833723e3f9be668b2ee633671c726f06bd3c
The branch, master has been updated
via f840833723e3f9be668b2ee633671c726f06bd3c (commit)
from 133e00edbeca192baad67ebaa9a9356ae5788051 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=f840833723e3f9be668b2ee633671c726f06bd3c
commit f840833723e3f9be668b2ee633671c726f06bd3c
Author: Michael Drake <[email protected]>
Commit: Michael Drake <[email protected]>
Low level cache: Squash use of uninitialised value.
Coverity issue:
CID 1419828: Memory - corruptions (UNINIT)
>>> Using uninitialized value "output_length".
diff --git a/content/llcache.c b/content/llcache.c
index 9c74fbd..2eb471d 100644
--- a/content/llcache.c
+++ b/content/llcache.c
@@ -1364,7 +1364,6 @@ llcache_serialise_metadata(llcache_object *object,
/* SSL certificates */
for (hloop = 0; hloop < cert_chain_depth; hloop++) {
- size_t output_length;
nsuerror res;
/* Certificate error code */
@@ -1381,7 +1380,7 @@ llcache_serialise_metadata(llcache_object *object,
/* DER certificate data in base64 encoding */
if (object->chain->certs[hloop].der != NULL) {
- output_length = datasize;
+ size_t output_length = datasize;
res = nsu_base64_encode(
object->chain->certs[hloop].der,
object->chain->certs[hloop].der_length,
@@ -1397,8 +1396,8 @@ llcache_serialise_metadata(llcache_object *object,
use++; /* allow for null */
if (use > datasize)
goto overflow;
- *(op + output_length) = 0;
op += use;
+ *(op - 1) = 0;
datasize -= use;
}
-----------------------------------------------------------------------
Summary of changes:
content/llcache.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/content/llcache.c b/content/llcache.c
index 9c74fbd..2eb471d 100644
--- a/content/llcache.c
+++ b/content/llcache.c
@@ -1364,7 +1364,6 @@ llcache_serialise_metadata(llcache_object *object,
/* SSL certificates */
for (hloop = 0; hloop < cert_chain_depth; hloop++) {
- size_t output_length;
nsuerror res;
/* Certificate error code */
@@ -1381,7 +1380,7 @@ llcache_serialise_metadata(llcache_object *object,
/* DER certificate data in base64 encoding */
if (object->chain->certs[hloop].der != NULL) {
- output_length = datasize;
+ size_t output_length = datasize;
res = nsu_base64_encode(
object->chain->certs[hloop].der,
object->chain->certs[hloop].der_length,
@@ -1397,8 +1396,8 @@ llcache_serialise_metadata(llcache_object *object,
use++; /* allow for null */
if (use > datasize)
goto overflow;
- *(op + output_length) = 0;
op += use;
+ *(op - 1) = 0;
datasize -= use;
}
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list
[email protected]
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/netsurf-commits-netsurf-browser.org
