Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/44e5aea7b50ab80ea2882bc89b0acf25f1b7730d
...commit
http://git.netsurf-browser.org/netsurf.git/commit/44e5aea7b50ab80ea2882bc89b0acf25f1b7730d
...tree
http://git.netsurf-browser.org/netsurf.git/tree/44e5aea7b50ab80ea2882bc89b0acf25f1b7730d
The branch, master has been updated
via 44e5aea7b50ab80ea2882bc89b0acf25f1b7730d (commit)
from 8924f0c7f97103a27576ca1a09b7272da2af0c04 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=44e5aea7b50ab80ea2882bc89b0acf25f1b7730d
commit 44e5aea7b50ab80ea2882bc89b0acf25f1b7730d
Author: Chris Young <[email protected]>
Commit: Chris Young <[email protected]>
Amiga: avoid use after free
Use the scheduler to trigger page info close as that does not allow the
same event to be in the queue multiple times
diff --git a/frontends/amiga/pageinfo.c b/frontends/amiga/pageinfo.c
index d980281..79e3ac6 100644
--- a/frontends/amiga/pageinfo.c
+++ b/frontends/amiga/pageinfo.c
@@ -99,9 +99,9 @@ static BOOL
ami_pageinfo_event(struct ami_corewindow *ami_cw, ULONG result)
{
if((result & WMHI_CLASSMASK) == WMHI_INACTIVE) {
- /* Window went inactive, so close it */
- ami_pageinfo_destroy(ami_cw);
- return TRUE;
+ /* Window went inactive, so schedule to close it */
+ ami_schedule(0, ami_pageinfo_close_cb, pageinfo_win);
+ /* NB: do not return TRUE here as we're still open for now */
}
return FALSE;
}
-----------------------------------------------------------------------
Summary of changes:
frontends/amiga/pageinfo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/frontends/amiga/pageinfo.c b/frontends/amiga/pageinfo.c
index d980281..79e3ac6 100644
--- a/frontends/amiga/pageinfo.c
+++ b/frontends/amiga/pageinfo.c
@@ -99,9 +99,9 @@ static BOOL
ami_pageinfo_event(struct ami_corewindow *ami_cw, ULONG result)
{
if((result & WMHI_CLASSMASK) == WMHI_INACTIVE) {
- /* Window went inactive, so close it */
- ami_pageinfo_destroy(ami_cw);
- return TRUE;
+ /* Window went inactive, so schedule to close it */
+ ami_schedule(0, ami_pageinfo_close_cb, pageinfo_win);
+ /* NB: do not return TRUE here as we're still open for now */
}
return FALSE;
}
--
NetSurf Browser
_______________________________________________
netsurf-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
